Page MenuHomePhabricator

Limit the number of ExternalData objects
Open, HighPublic


We should restrict how many ExternalData elements one map can have to prevent abuse. The actual number should be a configuration parameter. Would 5 be enough?

Event Timeline

Yurik created this task.Oct 30 2016, 4:56 PM
Restricted Application added a project: Discovery. · View Herald TranscriptOct 30 2016, 4:56 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald Transcript
MtDu added a subscriber: MtDu.Oct 30 2016, 6:42 PM

I'm interested in this task. However, I am not sure how to find the code section this pertains to. Could you guide me through it?

Yurik added a comment.Oct 30 2016, 7:35 PM

The code would need to be here

Use vagrant for the build and test environment, enable Kartographer role.
See for all the info. Ping us on irc if you run into any
priblems - #wikimedia-interactive channel.

MtDu added a comment.Oct 30 2016, 8:51 PM

Awesome. Yeah. That's where I thought it would need to be. I'm on the IRC channel now, but I don't see you there.

In regards to vagrant:
I participated in GCI last year, and contributed a little over the summer, but I haven't really used vagrant in terms of its testing environment. Usually, I just clone an extension and fix a bug, so I really want to get better at learning how to test.

As a result, I was wondering if you had any time to sort of walk me through and make sure my vagrant is up and running correctly and through the testing for this bug. I just want to use this as a stepping stone (hopefully) so I can contribute more in the future.
In addition, I had a working vagrant environment on my mac at on point, but since I spend most of my time on my laptop, getting the environment set up on my laptop is priority. Maybe sometime, I would appreciate it if you could just sit with me for a few hours and get functional vagrant testing environments working for both machines for me, or just my laptop is fine.

I know this is a lot to ask, so just let me know what you can do. Any help is appreciated . In addition, please let me know what time zone you are in so I can know of a general timeframe that you might be available on IRC.

Thanks so much!

Yurik added a comment.Oct 30 2016, 8:58 PM

Not sure about few hours )), but I could try to help get you started. I'll
be online in about half an hour. In the mean time, there is a very
extensive guide on on how to set vagrant up for MediaWiki
development. See how far you can get in if, and I will try to help with the

Yurik removed a project: Maps.Dec 15 2016, 4:39 AM
debt added a subscriber: debt.

Moving off the sprint board - the Discovery team won't be able to finish this work at this time.

MSantos moved this task from Unsorted to General on the Maps (Kartographer) board.Sep 11 2018, 2:50 PM