⚓ T149537 Visual diffing: indenting a list item produces an incorrect diff

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (41134af2b)	mediawiki/extensions/VisualEditor	master	+4 -4
Generalize DiffElement logic (improves lists and tables)	VisualEditor/VisualEditor	master	+203 -116
Fix splice typo	VisualEditor/VisualEditor	master	+1 -1

Status	Assigned	Task
Open	None	T143341 When re-starting a local draft, show the user a diff so they know what they're getting into
Open	None	T105173 HTML diffs of edits for everything
Resolved	Tchanders	T143350 Let users choose a visual or wikitext diff in the review-your-changes tab
Resolved	Tchanders	T149537 Visual diffing: indenting a list item produces an incorrect diff

Jdforrester-WMF triaged this task as High priority.Oct 31 2016, 5:54 PM

Jdforrester-WMF set the point value for this task to 1.

Change 319416 had a related patch set uploaded (by Tchanders):
Fix splice typo

The above patch fixes the exception (which was the same as T149528) so re-purposing this for a follow-up issue.

Change 319416 merged by jenkins-bot:
Fix splice typo

Actually the patch improved the rendering, but it still shows one item removed and two inserted:

Esanders changed the point value for this task from 1 to 8.Jan 17 2017, 5:21 PM

Change 340656 had a related patch set uploaded (by Tchanders):
[VisualEditor/VisualEditor] WIP Clean up DiffElement logic

Change 340656 merged by jenkins-bot:
[VisualEditor/VisualEditor] Generalize DiffElement logic (improves lists and tables)

Change 342651 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (bc6417ba5)

Change 342651 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (41134af2b)

Visual diffing: indenting a list item produces an incorrect diff
Closed, ResolvedPublic8 Estimated Story Points
Actions

	F4703788: pasted_file
	Nov 7 2016, 2:26 PM

	F4690327: pasted_file
	Nov 2 2016, 10:05 PM