Paragraphs are pulled out of infobox
Closed, ResolvedPublic
Actions

Description

Consider the source code

{| class="infobox"
|Let's try a paragraph of text here.
|
OMG paragraph
|-
|}


I am the lead paragraph of this ship.

Expected: "I am the lead paragraph of this ship." is shifted to the top of the section.
Actual: " OMG paragraph" becomes the lead paragraph.

We should not interfere with the infobox.

Test Plan

Visit http://reading-web-staging.wmflabs.org/wiki/InfoboxParagraph?mobileaction=beta on a mobile phone
Make sure the text "Paragraph inside infobox" appears in the infobox table.
Also make sure the text "Real first paragraph." appears above the infobox table.

Details

Related Gerrit Patches:

mediawiki/extensions/MobileFrontend : master

Only relocate immediate descendant paragraphs

Related Objects
Search...

Status	Assigned	Task
Open	None	T147641 [EPIC] Improve top of the article user experience - mobile
Resolved	None	T145216 MobileFormatter should relocate first paragraph ahead of infobox
Resolved	None	T149561 Paragraphs are pulled out of infobox

Event Timeline

Jdlrobson created this task.Oct 31 2016, 11:49 AM

This is even stranger when you use the following source code (navbox scrubbed but paragraph inside it is shown!)

{| class="infobox navbox"
|Infobox p|
OMG paragraph inside infobox
|-
|}

Real first paragraph.

Jdlrobson mentioned this in T149389: Not Found Error in MobileFormatter.Oct 31 2016, 12:03 PM

Change 318911 had a related patch set uploaded (by Phuedx):
Only relocate immediate descendant paragraphs

https://gerrit.wikimedia.org/r/318911

gerritbot added a project: Patch-For-Review.Oct 31 2016, 12:14 PM

Jdlrobson reassigned this task from bmansurov to phuedx.Oct 31 2016, 3:29 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-84-Zero-minutes-left board.

Jdlrobson added a subscriber: bmansurov.

ovasileva triaged this task as High priority.Oct 31 2016, 3:44 PM

Change 318911 merged by jenkins-bot:
Only relocate immediate descendant paragraphs

https://gerrit.wikimedia.org/r/318911

bmansurov updated the task description. (Show Details)Oct 31 2016, 6:34 PM

bmansurov moved this task from Code Review to Needs QA on the Reading-Web-Sprint-84-Zero-minutes-left board.

Over to you @Nicholas.tsg!

ovasileva moved this task from Incoming to 2016-17 Q2 on the Readers-Web-Backlog board.Nov 1 2016, 2:37 PM

Nicholas.tsg moved this task from Needs QA to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Nov 1 2016, 4:07 PM

@Nicholas.tsg the test URL has been updated. Please try again.

ovasileva moved this task from Needs QA to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Nov 1 2016, 5:46 PM

bmansurov moved this task from Needs More Work to Needs QA on the Reading-Web-Sprint-84-Zero-minutes-left board.Nov 1 2016, 6:37 PM

According to the attached screencaps, "Paragraph inside infobox" is appearing in the infobox table and "Real first paragraph" is appearing above the infobox table consistently, so this seems to be fixed. Here are the testing devices/environments I've checked,

iPhone 6S (iOS 10.0.1)