Page MenuHomePhabricator
Create Task
Maniphest T149576

Popups rendering engine should not need to generate link interaction tokens
Closed, ResolvedPublic
Actions

Description

Given the linkInteractionToken is only used when EventLogging it should be generated using processHovercardEvent and it should not be generated by the renderer.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
linkInteractionToken is managed by getMassagedDatamediawiki/extensions/Popupsmaster+50 -38
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Oct 31 2016, 2:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2016, 2:52 PM
Jdlrobson added a parent task: T146430: Popups render method should be dumb.Oct 31 2016, 2:52 PM
gerritbot subscribed.Oct 31 2016, 2:57 PM

Change 318137 had a related patch set uploaded (by Jdlrobson):
linkInteractionToken is managed by getMassagedData

https://gerrit.wikimedia.org/r/318137

gerritbot added a project: Patch-For-Review.Oct 31 2016, 2:57 PM
ovasileva triaged this task as High priority.Nov 1 2016, 2:34 PM
ovasileva added a project: Web-Team-Backlog-Archived.
ovasileva lowered the priority of this task from High to Medium.Nov 2 2016, 7:42 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.
gerritbot added a comment.Nov 28 2016, 5:58 PM

Change 318137 abandoned by Jdlrobson:
linkInteractionToken is managed by getMassagedData

https://gerrit.wikimedia.org/r/318137

Jdlrobson removed a project: Patch-For-Review.Nov 28 2016, 5:58 PM
ovasileva edited projects, added Page-Previews (2016-17-Q2-Goal); removed Page-Previews.Dec 19 2016, 10:59 PM
ovasileva moved this task from Backlog to Stalled on rewrite/potentially invalid on the Page-Previews (2016-17-Q2-Goal) board.Dec 20 2016, 12:31 AM
MBinder_WMF edited projects, added Page-Previews (2016-17-Q3-Goal); removed Page-Previews (2016-17-Q2-Goal).Jan 5 2017, 7:35 PM
MBinder_WMF moved this task from Backlog to Stalled on rewrite/potentially invalid on the Page-Previews (2016-17-Q3-Goal) board.Jan 5 2017, 7:46 PM
Jdlrobson closed this task as Resolved.Feb 15 2017, 10:07 PM
Jdlrobson claimed this task.

src/reducers/eventLogging.js is the only place that interacts with this now.

• Phabricator_maintenance moved this task from Triaged but Future to 2016-17 Q3 on the Web-Team-Backlog-Archived board.Mar 6 2018, 11:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits