Add CI to trending-edits repo
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bearND
	Oct 31 2016, 5:34 PM

Description

CI should automatically run the npm tests in the trending-edits source repo and vote based on the results.
After code review +2 and verification succeeded, a patch should be merged.

The setup can be similar to the mobileapps repo.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add config.yaml as symlink to config.dev.yaml	mediawiki/services/trending-edits	master	+1 -1
	Add CI to trending-edits repo	integration/config	master	+17 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T140102 [EPIC] As a user, I want to see see a list of currently trending articles
Resolved	pmiazga	T145662 Setup: Create trending-edits git repo
Resolved	• mobrovac	T149601 Add CI to trending-edits repo

Event Timeline

• bearND created this task.Oct 31 2016, 5:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2016, 5:34 PM

• bearND added a parent task: T145662: Setup: Create trending-edits git repo.Oct 31 2016, 5:34 PM

Jdlrobson added a project: Web-Team-Backlog-Archived.Nov 2 2016, 9:13 PM

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog-Archived board.

hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.Nov 3 2016, 7:59 PM

Change 320366 had a related patch set uploaded (by Jdlrobson):
Add CI to trending-edits repo

https://gerrit.wikimedia.org/r/320366

gerritbot added a project: Patch-For-Review.Nov 8 2016, 11:29 AM

Change 320366 merged by jenkins-bot:
Add CI to trending-edits repo

https://gerrit.wikimedia.org/r/320366

did a recheck on the last merged change https://gerrit.wikimedia.org/r/#/c/318507/3 but the npm test command fails with:

Error: ENOENT: no such file or directory, open '/home/jenkins/workspace/npm-node-4/test/utils/../../config.yaml'

@bearND are you able to sign off on this?

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-85-💩 board.Nov 8 2016, 11:41 AM

@bearND @mobrovac Jenkins is currently complaining with:

fs.js:549
12:00:02   return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
12:00:02                  ^
12:00:02 
12:00:02 Error: ENOENT: no such file or directory, open '/home/jenkins/workspace/npm-node-4/test/utils/../../config.yaml'
12:00:02     at Error (native)
12:00:02     at Object.fs.openSync (fs.js:549:18)

I don't get this error locally...
The file is there so I can only assume that there's something wrong with the CI setup @hashar
(note it doesn't seem to appear in https://phabricator.wikimedia.org/diffusion/query/all/)

The root of the repository has:

config.dev.yaml
config.prod.yaml

I have no idea how that is handled by other service though :(

ah... i see what's happening here. I have one but .gitignore is hiding it.
@mobrovac what's the correct action here? Should one be added or does it need to be setup elsewhere?