Page MenuHomePhabricator

Can't paste in HTML wrapped in unsupported tags, e.g. <legend>
Closed, ResolvedPublic8 Story Points

Description

How it's supposed to work:

  1. Insert > Media
  2. Click on desired photo from among search results.
  3. Click "Use this photo".
  4. In the Media settings dialog, triple-click to select the file name (plus the "(description page)" link).
  5. Command-C to copy the selected text
  6. Click in the caption box and paste the contents. (Backspace over the "description page" text.)
  7. Be happy that I didn't have to re-type that long name.

What's happening instead:

  1. Insert > Media
  2. Click on desired photo from among search results
  3. Click "Use this photo"
  4. In the Media settings dialog, triple-click to select the file name (plus the "(description page)" link).
  5. Command-C to copy the selected text
  6. Click in the caption box and paste the contents.
  7. Get nothing pasted. Be sad.

This problem is reported in Chrome 43 and 44, but it works correctly in (at least) Safari 10.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 1 2016, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders renamed this task from [Regression?] Can no longer copy file name from Media Settings dialog in Chrome to [Regression?] Can no longer paste file name from Media Settings dialog.Nov 1 2016, 11:08 PM
Esanders added a subscriber: Esanders.

The filename copies fine, but because it is now wrapped in a <legend> tag, VE filters it out on paste.

As a work-around you can force a plain text paste using CTRL+SHIFT+V (Command+Shift+V on Mac?)

Esanders renamed this task from [Regression?] Can no longer paste file name from Media Settings dialog to Can't paste in HTML wrapped in unsupported tags, e.g. <legend>.Nov 1 2016, 11:19 PM
Jdforrester-WMF triaged this task as Normal priority.Nov 8 2016, 8:11 PM
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Kerry reports that forcing a plain-text paste works, and also that the problem is only when copying the beginning of the file name.

Change 320763 had a related patch set uploaded (by Esanders):
Add HTML blacklist for content which doesn't have a model type yet

https://gerrit.wikimedia.org/r/320763

Change 320763 merged by jenkins-bot:
Add HTML blacklist for content which doesn't have a model type yet

https://gerrit.wikimedia.org/r/320763

Change 321686 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (c8389bd)

https://gerrit.wikimedia.org/r/321686

Change 321686 merged by jenkins-bot:
Update VE core submodule to master (c8389bd)

https://gerrit.wikimedia.org/r/321686