Page MenuHomePhabricator

Add logic to collapse / expand aspects in the conflict column
Closed, ResolvedPublic

Description

Event Timeline

Tobi_WMDE_SW moved this task from Todo to Proposed on the WMDE-TechWish board.
Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-TechWish board.
Tobi_WMDE_SW moved this task from Todo to Proposed on the WMDE-TechWish board.
Tobi_WMDE_SW renamed this task from Add logic to colaps / expand aspects in the conflict column to Add logic to collaps / expand aspects in the conflict column.Nov 4 2016, 4:03 PM
Addshore renamed this task from Add logic to collaps / expand aspects in the conflict column to Add logic to collapse / expand aspects in the conflict column.Nov 11 2016, 6:38 PM

Change 324268 had a related patch set uploaded (by WMDE-Fisch):
[WIP] Add logic to show and hide unchanged text

https://gerrit.wikimedia.org/r/324268

Two UX-y views on this:

a) If we collapse/expand the unchanged text everything jumps and the user must orient themselves anew. We could could relieve this with a (quick!) animation to fade from one state to the other. Technology-wise CSS transforms would be good (since potentially hardware accelerated). If jQuery falls back on such, it is fairly easy.

b) Since "…" could be part of a text, too, I wonder if some sort of fadeout would communicate the collapsed text better. Here an image of how this could look like:

fadeout.png (53×223 px, 2 KB)

c) I assume that if text is hidden, people will click on the … or the faded out parts to make it appear again. It would be a logical mapping, even if it makes all text appear instead of only the collapsed text at the place of the click.

Change 324268 merged by jenkins-bot:
Add logic to show and hide unchanged text

https://gerrit.wikimedia.org/r/324268

Change 330112 had a related patch set uploaded (by WMDE-Fisch):
Fade-out text instead of using ellipsis

https://gerrit.wikimedia.org/r/330112

Change 330112 merged by jenkins-bot:
Fade-out text instead of using ellipsis

https://gerrit.wikimedia.org/r/330112

Change 330115 had a related patch set uploaded (by WMDE-Fisch):
Expand collapsed text on click

https://gerrit.wikimedia.org/r/330115

Change 330120 had a related patch set uploaded (by WMDE-Fisch):
Collaps and expand smoothly

https://gerrit.wikimedia.org/r/330120

Change 330115 merged by jenkins-bot:
Expand collapsed text on click

https://gerrit.wikimedia.org/r/330115

Change 330120 merged by jenkins-bot:
Collapse and expand smoothly

https://gerrit.wikimedia.org/r/330120