Page MenuHomePhabricator

Allow editing of image captions in place
Closed, ResolvedPublic8 Story Points

Description

Most of the technical reasons why we didn't do this originally have since been overcome (e.g. handling a nested ce=true inside ce=false like we've since done with tables) and it would make for a more intuitive user experience.

We could either keep the media dialog as is, or get rid of the caption sub-surface and move everything onto one page.

Event Timeline

Esanders created this task.Nov 1 2016, 11:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2016, 11:25 PM

Change 320068 had a related patch set uploaded (by Esanders):
Factor out active node functionality from SectionNode for captions

https://gerrit.wikimedia.org/r/320068

Change 320070 had a related patch set uploaded (by Esanders):
WIP Edit image captions in place

https://gerrit.wikimedia.org/r/320070

This should work for galleries too once we have native Parsoid support for them (T149602).

Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Johan added a subscriber: Johan.

What does "in place" mean here? As opposed to?

What does "in place" mean here? As opposed to?

As opposed to in a dialog, like now.

Editing in a caption:

Editing "in-place"/directly in the document:

Change 320068 merged by jenkins-bot:
Factor out active node functionality from SectionNode for captions

https://gerrit.wikimedia.org/r/320068

Change 320070 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Edit image captions in place

https://gerrit.wikimedia.org/r/320070

Deskana closed this task as Resolved.Jul 24 2017, 4:15 PM
Deskana added a subscriber: Deskana.

Cool!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 24 2017, 4:15 PM
TheDJ awarded a token.Jul 24 2017, 5:57 PM