Page MenuHomePhabricator

Enable making configuration changes on a per-language basis
Closed, ResolvedPublic

Description

Within CirrusSearch we need the ability to turn some settings on/off based on the language of the wiki. The most recent example is that the per-field bm25 query builder we are using doesn't seem to work particularly well on languages without spaces between their words (zh, ja, and several more). We would like to still ship this feature out to most languages, where it has tested to be an improvement over the previous implementation, but continue serving the query-string query based implementation to languages where it is not an improvement.

We could of course list out all the wiki's that use the language, but that would be tedious, error prone, and overly verbose. Instead add a 'wikiTag', per SiteConfiguration::get, that allows defining settings based on the language of the wiki in question.

Event Timeline

Change 319253 had a related patch set uploaded (by EBernhardson):
Add a wiki configuration tag for configured language

https://gerrit.wikimedia.org/r/319253

Change 319253 merged by jenkins-bot:
Add a wiki configuration tag for configured language

https://gerrit.wikimedia.org/r/319253

Mentioned in SAL (#wikimedia-operations) [2016-12-06T14:40:41Z] <zfilipin@tin> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:319253|Add a wiki configuration tag for configured language (T149755)]] (duration: 00m 47s)

Patch in Gerrit has been merged. @EBernhardson: Can this task be resolved, or is there more to do in this task? Asking as you are set as task assignee.