Page MenuHomePhabricator

Special:Log/patrol with "manual" type returns automatic patrols
Closed, DuplicatePublic

Description

See Special:Log/patrol for User:ClueBot_NG, where the "type of patrol" is set to manual: https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=patrol&user=ClueBot+NG&page=&year=&month=-1&tagfilter=&subtype=patrol

The results say ...ClueBot NG... automatically marked revision ... as patrolled. It would seem that "automatic" patrols should not be reported.

Doing the same thing for User:MusikAnimal (manual type): https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=patrol&user=MusikAnimal&page=&year=&month=-1&tagfilter=&subtype=patrol

The results say ...MusikAnimal ... mark revision ... as patrolled, and not automatic. Run the same query for MusikAnimal with "automatic" set as the type and you get ...MusikAnimal... automatically marked revision ... as patrolled as you would expect.

I'm led to believe manual patrols means user explicitly clicked "marked this page as patrolled", among other ways, and not patrolling as a result of having the autopatrol user right, which ClueBot_NG has (as does MusikAnimal). Obviously ClueBot did not manually click on anything, and I presume it is not programmed to manually patrol anything.

This anomaly holds true not just for bots but for other users who are autopatrolled, for instance User:Mjs1991

Is this a bug or perhaps I don't understand how patrols work?

Event Timeline

Task T136493, which I have created 5 months ago, is essentially about the same bug.

T149344 could be related?

Nice find. It might be related in some instances, but I'm seeing pages that were never redirects being recorded as manual patrols but showing up as automatic. This I can confirm via SQL as well, for instance this edit was marked as a manual patrol, as evidenced by https://quarry.wmflabs.org/query/13789

@GeoffreyT2000 Actually... it looks like the bug might have been fixed in late March 2016. I see that is the most recent "manual" patrol by User:ClueBot_NG, and sure enough when I check my own manual patrols for March I see the same https://en.wikipedia.org/w/index.php?title=Special:Log&offset=20160412165201&type=patrol&user=MusikAnimal&page=&tagfilter=&subtype=patrol&month=4

It's still interesting they appear as "automatic" at Special:Log, even though they were recorded as manual. Perhaps there's a way to fix that. I think that information may live in the log_params column, which is not easy to query.

T149344 could be related?

Not related.

In T149756#2762030, @GeoffreyT2000 wrote:

Task T136493, which I have created 5 months ago, is essentially about the same bug.

Yes, this can be merged in.