Page MenuHomePhabricator

Deploy WikipediaExtracts extension
Open, Needs TriagePublic

Event Timeline

Dereckson created this task.Nov 2 2016, 2:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 2:34 AM

Hmm, should this extension be deployed on the Beta Cluster before going into production? If so, then I hereby request deployment to the Beta Cluster.

Reedy added a subscriber: Reedy.EditedJan 19 2019, 8:32 PM

Needs CI enabling for the extension to make sure it's passing tests (phpcs, linting etc); you shouldn't be doing V+2 yourself and submitting etc

'exchars' => array_key_exists( 'chars', $params ) ? $params['chars'] : '',

Might aswell just use newer PHP stuff

'exchars' => $params['chars'] ?? '',

And then just remove the & from this, objects are always passed by reference

	/**
	 * Main hook
	 *
	 * @param Parser &$parser Parser object
	 */
	public static function onParserFirstCallInit( Parser &$parser ) {
		$parser->setFunctionHook( 'WikipediaExtract', 'WikipediaExtracts::onFunctionHook' );
	}

Change 485376 had a related patch set uploaded (by Sophivorus; owner: Sophivorus):
[mediawiki/extensions/WikipediaExtracts@master] Respond to third code review by Reedy

https://gerrit.wikimedia.org/r/485376

Sophivorus added a comment.EditedJan 19 2019, 8:47 PM

Thanks for the quick response, Reedy. I know that doing V+2 myself and submitting is not good practice, but because my previous patch remained unmerged for so long, it became incompatible with the master branch and I had to manually re-do it, which is annoying, and I didn't want that to happen again.

Anyway, I just found the CI tutorials. I'll check them out and do my best to enable CI for the extension so that Jenkins does its thing.

I also updated the on-wiki documentation for ParserFirstCallInit.

greg removed a subscriber: greg.Jan 23 2019, 11:16 PM

Change 492342 had a related patch set uploaded (by Sophivorus; owner: Sophivorus):
[integration/config@master] Add Extension:WikipediaExtracts

https://gerrit.wikimedia.org/r/492342

Change 492342 abandoned by Sophivorus:
Add Extension:WikipediaExtracts

Reason:
It seems like WikipediaExtracts was already in layout.yaml !!

https://gerrit.wikimedia.org/r/492342

https://gerrit.wikimedia.org/r/485376

@Reedy This patch is already V+2 and CR+2 but Jenkins won't merge it. WikipediaExtracts is already in integration/config/zuul/layout.yaml and my email is also in the whitelist. Do you know what are we missing? Thanks!

Change 485376 merged by jenkins-bot:
[mediawiki/extensions/WikipediaExtracts@master] Respond to third code review by Reedy

https://gerrit.wikimedia.org/r/485376

@Reedy Thanks! So now that that's done, do you think there's anything else missing before this extension can be deployed in the Beta Cluster?

Subtask T149766 is still open, I'd say