Page MenuHomePhabricator

ElectronPdfServiceHooks::onSidebarBeforeOutput() prevents other hooks run running in some cases
Closed, ResolvedPublic

Description

  • ElectronPdfServiceHooks::onSidebarBeforeOutput() - This returns false if it is not a view/purge action. Returning false prevents all other subscribers to this hook from running. I don't think that is wanted in this case.

Event Timeline

Change 319281 had a related patch set uploaded (by WMDE-Fisch):
Let hook return true in all cases

https://gerrit.wikimedia.org/r/319281

Change 319281 merged by jenkins-bot:
Let hook return true in all cases

https://gerrit.wikimedia.org/r/319281