Page MenuHomePhabricator

ElectronPdfServiceHooks::onSidebarBeforeOutput() prevents other hooks run running in some cases
Closed, ResolvedPublic

Description

  • ElectronPdfServiceHooks::onSidebarBeforeOutput() - This returns false if it is not a view/purge action. Returning false prevents all other subscribers to this hook from running. I don't think that is wanted in this case.

Event Timeline

Addshore created this task.Nov 2 2016, 8:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 8:50 AM
WMDE-Fisch moved this task from Proposed to Sprint ready on the WMDE-QWERTY-Team board.

Change 319281 had a related patch set uploaded (by WMDE-Fisch):
Let hook return true in all cases

https://gerrit.wikimedia.org/r/319281

Addshore moved this task from Sprint ready to Done on the WMDE-QWERTY-Team board.Nov 2 2016, 9:40 AM
Addshore closed this task as Resolved.Nov 2 2016, 9:47 AM

Change 319281 merged by jenkins-bot:
Let hook return true in all cases

https://gerrit.wikimedia.org/r/319281

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Nov 8 2016, 3:19 PM