Page MenuHomePhabricator

SpecialElectronPdf switch statement has misleading fall through to default
Closed, ResolvedPublic


  • In the switch statement in SpecialElectronPdf.php line 48 - the redirect case falls through to the default case. Well this doesn't overly matter since the page ends up a redirect, it could be a little confusing if someone was refactoring the code at a later date and didn't notice. I think the code would be more clear if that case also had a return.

Event Timeline

Change 319285 had a related patch set uploaded (by WMDE-Fisch):
Fix switch fall through

Change 319285 merged by jenkins-bot:
Fix switch fall through