Page MenuHomePhabricator

SpecialElectronPdf switch statement has misleading fall through to default
Closed, ResolvedPublic

Description

  • In the switch statement in SpecialElectronPdf.php line 48 - the redirect case falls through to the default case. Well this doesn't overly matter since the page ends up a redirect, it could be a little confusing if someone was refactoring the code at a later date and didn't notice. I think the code would be more clear if that case also had a return.

Event Timeline

Addshore created this task.Nov 2 2016, 8:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 8:52 AM

Change 319285 had a related patch set uploaded (by WMDE-Fisch):
Fix switch fall through

https://gerrit.wikimedia.org/r/319285

Change 319285 merged by jenkins-bot:
Fix switch fall through

https://gerrit.wikimedia.org/r/319285

Addshore closed this task as Resolved.Nov 2 2016, 10:11 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Nov 8 2016, 3:19 PM