Page MenuHomePhabricator

Remove double encoding of $collectionURL in ElectronPdfServiceHooks::generateSelectionScreenLink()
Closed, ResolvedPublic

Description

  • In ElectronPdfServiceHooks::generateSelectionScreenLink() - 'coll-download-url' => urlencode( $collectionUrl ) - This is double encoding the url.

Event Timeline

Addshore created this task.Nov 2 2016, 8:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 8:54 AM
WMDE-Fisch moved this task from Proposed to Sprint ready on the WMDE-QWERTY-Team board.

Change 319283 had a related patch set uploaded (by WMDE-Fisch):
Remove double encoding of URL

https://gerrit.wikimedia.org/r/319283

Tobi_WMDE_SW closed this task as Resolved.Nov 2 2016, 10:15 AM
Tobi_WMDE_SW moved this task from Currently in sprint to Done on the WMDE-QWERTY-Team board.

Change 319283 merged by jenkins-bot:
Remove double encoding of URL

https://gerrit.wikimedia.org/r/319283

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Nov 8 2016, 3:18 PM