Page MenuHomePhabricator

ElectronPdfServiceHooks remove double escaping
Closed, ResolvedPublic

Description

  • Line 49 ElectronPdfServiceHooks - 'text' => $skin->msg( 'electronPdfService-sidebar-portlet-print-text' )->escaped(... (and similar lines)This is double escaping. BaseTemplate::makeLink will escape the text key before outputting.

Event Timeline

Addshore created this task.Nov 2 2016, 8:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 8:55 AM
WMDE-Fisch moved this task from Proposed to Sprint ready on the WMDE-QWERTY-Team board.

Change 319282 had a related patch set uploaded (by WMDE-Fisch):
Avoid double escaping

https://gerrit.wikimedia.org/r/319282

Addshore moved this task from Sprint ready to Done on the WMDE-QWERTY-Team board.Nov 2 2016, 9:47 AM
Addshore closed this task as Resolved.Nov 2 2016, 9:48 AM

Change 319282 merged by jenkins-bot:
Avoid double escaping

https://gerrit.wikimedia.org/r/319282

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Nov 8 2016, 3:18 PM