Page MenuHomePhabricator

Add hard limit to SpecialElectronPdf::writeToTempFile
Closed, ResolvedPublic

Description

  • It would be nice if writeToTempFile kept track of how much data it was writing, and had some sort of hard limit as a defense in depth mechanism in case there's ever a bug where the user can generate a gb big pdf file.

Event Timeline

Addshore created this task.Nov 2 2016, 8:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 8:57 AM
Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-QWERTY-Team board.Nov 2 2016, 10:09 AM
Tobi_WMDE_SW moved this task from Todo to Sprint ready on the WMDE-QWERTY-Team board.

Change 320195 had a related patch set uploaded (by Tobias Gritschacher):
Introduce hard limit for document byte size

https://gerrit.wikimedia.org/r/320195

Change 320195 merged by jenkins-bot:
Introduce hard limit for document byte size

https://gerrit.wikimedia.org/r/320195

Tobi_WMDE_SW closed this task as Resolved.Nov 8 2016, 12:05 PM
Tobi_WMDE_SW moved this task from Currently in sprint to Done on the WMDE-QWERTY-Team board.
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Nov 8 2016, 3:21 PM