Page MenuHomePhabricator

[BUG] News notification not dismissed after tapping "Save for later"
Closed, ResolvedPublic

Description

Steps to reproduce

  1. receive a news notification
  2. tap "save for later"

Expected results

Article is saved, notification is dismissed

Actual results

Article is saved, notification is not dismissed

Event Timeline

This appears to be a bug on Apple's side. We're making the right completion call but the notification isn't actually dismissed.

We could work around this by having the save action open the app... but that doesn't seem like what the user would expect.

https://github.com/wikimedia/wikipedia-ios/pull/1021/commits/aab8ec8826d679728859cf36750d91fbc9e9f295 < - doesn't work before or after the change, or with any action other than the built in dismissal.

Another option would be to add some sort of confirmation UI to indicate that the save action was applied - then allow the user to manually dismiss or perform other actions.

Ok found a fix in another part of the API - the notification category erroneously had UNNotificationActionOptionForeground which still allowed you to dismiss in 10.0, but only allowed opening the app on 10.1.

But to clarify, is it OK to just dismiss on save for later or should there be some sort of visual indication of the save?

@JoeWalsh this is the video that @Nirzar made of a 'Save article' confirmation on a trending notification:
https://drive.google.com/open?id=0B2l28Vq6XYKNOENGQnQtOXlXZVE

Screenshot of confirmation

Screen Shot 2016-11-02 at 2.06.53 PM.png (1×758 px, 259 KB)

Tick png

tick.png (80×80 px, 2 KB)

If we need to scale it back from an animation, I can definitely do up a mock for a static text/image lockup.

Additionally, would it be possible to also make 'Save for later' selected or un-clickable after the user has completed the action? If we aren't going to have the 'Save for later' action be toggle-able from the notificaiton that is.

Also just to add, MVP would probably be dismissing the notification after the user takes an action with a future goal of having some sort of confirmation message.

@cmadeo could I get a PDF version of the checkmark icon? Thanks!