phpcs should enforce spacing in function signature
Closed, ResolvedPublic
Actions

Description

During code review we discovered a linting inconsistency
https://gerrit.wikimedia.org/r/#/c/319067/7/tests/phpunit/MobileFormatterTest.php,unified

private function makeSectionHeading( $heading, $innerHtml, $sectionNumber=1 ) {

private function makeSectionHeading( $heading, $innerHtml, $sectionNumber = 1 ) {

We should enforce and standardise on one of these styles

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: add phpcs rule for function declaration equals spacing	mediawiki/extensions/MobileFrontend	master	+12 -2

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Nov 3 2016, 10:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2016, 10:45 AM

Jdlrobson added projects: MobileFrontend, Web-Team-Backlog.Nov 3 2016, 10:46 AM

Jdlrobson updated the task description. (Show Details)

• jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Nov 14 2016, 6:30 PM

It is possible by adding to rules.xml following rule:

<rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
        <properties>
                <property name="equalsSpacing" value="1" />
                <property name="requiredSpacesAfterOpen" value="1"/>
                <property name="requiredSpacesBeforeClose" value="1" />
        </properties>
</rule>

phpcs output after enabling Squiz.Functions.FunctionDeclarationArgumentSpacing can be found here: https://phabricator.wikimedia.org/P4433

• jhobs triaged this task as Low priority.Nov 15 2016, 6:40 PM

Change 333831 had a related patch set uploaded (by Niedzielski):
Hygiene: add phpcs rule for function declaration equals spacing

https://gerrit.wikimedia.org/r/333831

gerritbot added a project: Patch-For-Review.Jan 24 2017, 2:32 AM