Page MenuHomePhabricator

Fix MobileFrontend broken Makefile tasks
Closed, ResolvedPublic1 Story Points

Description

MobileFrontend project has outdated Makefile and some tasks fail.

Failing tasks:

  • jscs, jshinttests and jshint - mssing global grunt CLI
  • qunit - missing global grunt CLI plus missing MediaWiki nodejs dependencies
  • phpunit - missing --wiki parameter

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterFix broken jshinttets Makefile task
mediawiki/extensions/MobileFrontend : masterFix broken Makefile

Event Timeline

pmiazga created this task.Nov 4 2016, 6:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2016, 6:43 PM

Change 319904 had a related patch set uploaded (by Pmiazga):
Fix broken Makefile

https://gerrit.wikimedia.org/r/319904

phuedx set the point value for this task to 1.Nov 7 2016, 9:38 AM

@pmiazga: We try to estimate all work that makes it into the sprint. Does 1 sound reasonable?

Change 319904 merged by jenkins-bot:
Fix broken Makefile

https://gerrit.wikimedia.org/r/319904

#phuedx - yes, 1 sounds reasonable, I was going to mention this task today at Kickoff/Triage and do estimation/notify other team members about this unplanned work

I'm running a local MediaWiki instance and having 2 problems as described below:

Running make jshinttests results in:

npm WARN grunt-mkdir@0.1.2 requires a peer of grunt@~0.4.0 but none was installed.
npm WARN grunt-qunit-istanbul@0.4.5 requires a peer of grunt@~0.4.0 but none was installed.
npm WARN grunt-svg2png@0.2.5 requires a peer of grunt@~0.4.0 but none was installed.
npm WARN stylelint-config-wikimedia@0.3.0 requires a peer of stylelint@^7.0.2 but none was installed.
Running "jshint:tests" (jshint) task
Verifying property jshint.tests exists in config...ERROR

Unable to process task.

Warning: Required config property "jshint.tests" missing. Use --force to continue.
Aborted due to warnings.
make: *** [jshinttests] Error 3

Running make qunit results in:

07 11 2016 09:55:18.848:WARN [Chrome 53.0.2785 (Mac OS X 10.11.6)]: Disconnected (1 times), because no message in 60000 ms.
Chrome 53.0.2785 (Mac OS X 10.11.6) ERROR

Disconnected, because no message in 60000 ms.

07 11 2016 09:55:18.851:DEBUG [karma]: Run complete, exiting.
07 11 2016 09:55:18.852:DEBUG [launcher]: Disconnecting all browsers
07 11 2016 09:55:19.018:DEBUG [launcher]: Process Chrome exited with code 0
07 11 2016 09:55:19.019:DEBUG [temp-dir]: Cleaning temp dir /var/folders/09/hvh5v2w52f5fjxmb63x1mvdm0000gn/T/karma-24664192
07 11 2016 09:55:19.057:DEBUG [launcher]: Finished all browsers
Warning: Task "karma:main" failed. Use --force to continue.
Aborted due to warnings.
make: *** [qunit] Error 3

@bmansurov

make jshinttests I have to check that one, looks like typo (extra s, Gruntfile has jshint:test task, strange.

make qunit - this task has to be executed on your host (it doesn't work in vagrant because there is no chrome/ui) inside vagrant. If chrome is not found it dies, then after starting chrome it tries to connect to karma proxy using local env variables (MW_SERVER and MW_SCRIPT_PATH). If those variables are pointing to wrong host script will die after 60 seconds because it cannot connect. Please check your env variables first (maybe they are pointing to vagrant but you're hosting mediawiki on your host)

Verified - make jshinttests fails, it'a typo, calls incorrect grunt task.

Change 320222 had a related patch set uploaded (by Pmiazga):
Fix broken jshinttets Makefile task

https://gerrit.wikimedia.org/r/320222

bmansurov closed this task as Resolved.Nov 7 2016, 4:58 PM
bmansurov removed bmansurov as the assignee of this task.

@pmiazga thanks for fixing up jshinttests. Also after using the correct values for MW_SERVER and MW_SCRIPT_PATH I can run make qunit without an error too.

Change 320222 merged by jenkins-bot:
Fix broken jshinttets Makefile task

https://gerrit.wikimedia.org/r/320222

phuedx added a comment.Nov 7 2016, 5:07 PM

^ Weird. I thought I tested that. Mibad.