Page MenuHomePhabricator

Maps "align" attribute definitions, review and fix
Closed, ResolvedPublic

Description

I created a page to showcase the different presentation/alignment options we have at https://www.mediawiki.org/wiki/User:JGirault_(WMF)/QA/MapAlignment

  • Current state:
FramedFrameless
!align (default)right left
align=leftleft left
align=centercenter center
align=rightright left
  • TODOs:
    • Confirm default alignment for both framed and frameless.
    • Fix frameless right alignment

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
  • Confirm default alignment for both framed and frameless.

We have same question for Graphs, and @MaxSem and I decided to avoid confusion of having different defaults for each mode: (see T147768#2773162)
Maps and Graphs will have right alignment by default.

Updating the original ticket.

Change 319964 had a related patch set uploaded (by JGirault):
Fixes frameless right alignment not being applied

https://gerrit.wikimedia.org/r/319964

  • Fix frameless right alignment

With this patch :

  • Alignment: align attribute
FramedFrameless
!align (default)rightright
align=leftleftleft
align=centercentercenter
align=rightrightright
Screenshot

Change 319964 merged by jenkins-bot:
Fixes frameless right alignment not being applied

https://gerrit.wikimedia.org/r/319964

@JGirault I updated your page a bit to have a lot of text around the graph. Seems good.