Page MenuHomePhabricator

Preferences 'Restore all default settings' option does not apply to 'Flow on user talk' Beta feature
Closed, DuplicatePublic

Description

  1. Log in to betalabs (or testwiki) and go to Preferences
  2. Change some settings - e.g. select Appearance - Skin 'monobook', Beta - 'ORES' (betalabs only) and 'Flow on user talk'
  3. Make sure that Preferences changes are saved - the skin should change, ORES displays highlighted scoring on Special:RecentChanges and a User talk page is in Flow format.
  4. Go to Preferences and click on 'Restore all default settings (in all sections)', and then click to confirm.
  5. On Preferences -Beta page the checkboxes for ORES and 'Flow on user talk' option will be unchecked.

Observe:

  • the skin will be changed to default Vector
  • the ORES scoring/highlighting is gone
  • but the User talk page still is displayed as a Flow board

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2016, 11:17 PM

If a user after clicking on 'Restore all default settings (in all sections)' attempts to click on 'Flow on user talk'

  • User talk page will unchanged - it will be still in Flow format
  • when a user attempts to disable Flow by unchecking the option, the User talk page displays the following error (found at testwiki):
Error
The Flow workflow is not associated with this page.

Return to Main Page.

[WB0YcApAAEYAAgIh7PwAAADJ] /wiki/User_talk:Zilant1 Flow\Exception\InvalidDataException from line 126 of /srv/mediawiki/php-1.29.0-wmf.1/extensions/Flow/includes/WorkflowLoaderFactory.php: Flow workflow is for different page

Backtrace:

#0 /srv/mediawiki/php-1.29.0-wmf.1/extensions/Flow/includes/WorkflowLoaderFactory.php(99): Flow\WorkflowLoaderFactory->loadWorkflowById(Title, Flow\Model\UUID)
#1 /srv/mediawiki/php-1.29.0-wmf.1/extensions/Flow/includes/Actions/Action.php(105): Flow\WorkflowLoaderFactory->createWorkflowLoader(Title)
#2 /srv/mediawiki/php-1.29.0-wmf.1/extensions/Flow/includes/Actions/ViewAction.php(20): Flow\Actions\FlowAction->showForAction(string, OutputPage)
#3 /srv/mediawiki/php-1.29.0-wmf.1/extensions/Flow/includes/Actions/Action.php(50): Flow\Actions\ViewAction->showForAction(string)
#4 /srv/mediawiki/php-1.29.0-wmf.1/includes/MediaWiki.php(505): Flow\Actions\FlowAction->show()
#5 /srv/mediawiki/php-1.29.0-wmf.1/includes/MediaWiki.php(289): MediaWiki->performAction(Article, Title)
#6 /srv/mediawiki/php-1.29.0-wmf.1/includes/MediaWiki.php(861): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.29.0-wmf.1/includes/MediaWiki.php(522): MediaWiki->main()
#8 /srv/mediawiki/php-1.29.0-wmf.1/index.php(43): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}
Etonkovidova added a comment.EditedDec 1 2016, 8:09 PM

Re-checked on testwiki with i 1.29.0-wmf.4 - no errors in the case

when a user attempts to disable Flow by unchecking the option, the User talk page displays the following error (found at testwiki).

  • 'Restore all default settings' still does not apply to 'Flow on user talk page' option; users still see their User talk page in Flow format.
  • The workaround for a user that is stuck with the user talk page in Flow format is to check 'Flow on user talk' ->Save -> uncheck 'Flow on user talk'->Save. The previously archived user talk wikitext page will be displayed.
  • another thing to check after the fix - if during the workaround described above, after check 'Flow on user talk' ->Save, a user will go to his User talk page, he will see again the intro.