Full screen map does not hide sidebar in "Cologne Blue" skin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Yurik
	Nov 7 2016, 2:41 AM

Description

Switch to "Cologne Blue" skin, click on any maplink or mapframe items. The full screen shows map, but keeps the left sidebar on the top.

Details

	Subject	Repo	Branch	Lines +/-
	Remove unnecessary z-index on the sidebar	mediawiki/skins/CologneBlue	master	+0 -1

Customize query in gerrit

Event Timeline

Yurik created this task.Nov 7 2016, 2:41 AM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptNov 7 2016, 2:41 AM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald Transcript

• JGirault added a project: Maps-Sprint.Nov 7 2016, 9:42 PM

• JGirault claimed this task.Nov 7 2016, 10:50 PM

• JGirault moved this task from Backlog to In progress on the Maps-Sprint board.

Wow, the skin sets a [[ https://github.com/wikimedia/mediawiki-skins-CologneBlue/blob/e7dfba7382435b7eb526dae5b2289a80595bf24d/resources/screen.css#L36 | z-index: 99; ]] on that sidebar ...

I guess this is rather a problem of this skin not working with .oo-ui-windowManager-modal > .oo-ui-dialog, using z-index: 4;

• JGirault added a project: OOUI.Nov 8 2016, 1:27 AM

Yurik removed projects: Maps-Sprint, good first task.Nov 8 2016, 5:33 AM

matmarex edited projects, added CologneBlue; removed OOUI.Nov 8 2016, 9:16 AM

Change 320353 had a related patch set (by Bartosz Dziewoński) published:
It's not needed here at all, and it causes the sidebar to overlap OOjs UI dialogs.

https://gerrit.wikimedia.org/r/320353

gerritbot added a project: Patch-For-Review.Nov 8 2016, 9:17 AM

matmarex claimed this task.Nov 8 2016, 9:18 AM

matmarex lowered the priority of this task from Low to Lowest.

• JGirault added a project: Maps-Sprint.Nov 9 2016, 12:00 AM

• JGirault moved this task from In progress to Needs review on the Maps-Sprint board.

Change 320353 merged by jenkins-bot:
Remove unnecessary z-index on the sidebar

https://gerrit.wikimedia.org/r/320353

matmarex closed this task as Resolved.Nov 9 2016, 12:15 AM

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)).Nov 9 2016, 1:00 AM

Full screen map does not hide sidebar in "Cologne Blue" skinClosed, ResolvedPublicActions

Description

Details

Event Timeline

Full screen map does not hide sidebar in "Cologne Blue" skin
Closed, ResolvedPublic
Actions