Page MenuHomePhabricator
Create Task
Maniphest T150205

Refactor SpecialNewEntity so it can be extended to SpecialNewLexeme
Closed, ResolvedPublic
Actions

Description

Right now SpecialNewEntity has so many incompatible parts that makes impossible to properly be used by SpecialNewLexeme. That needs to be fixed.

Details

SubjectRepoBranchLines +/-
Reduced number of fields for some Special pages and added constructor DImediawiki/extensions/Wikibasemaster+79 -66
SpecialNewLexeme now uses HTMLItemReferenceFieldmediawiki/extensions/WikibaseLexememaster+4 -45
SpecialNewLexeme refactoring and addition of input validationmediawiki/extensions/WikibaseLexememaster+181 -349
Added item reference field typemediawiki/extensions/Wikibasemaster+176 -0
Restructured and added SpecialNewLexeme testsmediawiki/extensions/WikibaseLexememaster+148 -21
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Nov 7 2016, 8:14 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptNov 7 2016, 8:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ladsgroup renamed this task from Regactor SpecialNewEntity so it can be extended to SpecialNewLexme to Refactor SpecialNewEntity so it can be extended to SpecialNewLexme.Nov 8 2016, 12:13 AM
Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Nov 10 2016, 1:48 PM
Ladsgroup moved this task from In progress to Later on the User-Ladsgroup board.Nov 14 2016, 6:45 AM
Ladsgroup edited projects, added Wikidata-Former-Sprint-Board; removed WMDE-TLA-Team.Nov 18 2016, 10:55 AM
Ladsgroup moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.Nov 18 2016, 10:55 AM
WMDE-leszek moved this task from Backlog to Proposed on the Wikidata-Former-Sprint-Board board.Dec 6 2016, 2:46 PM
daniel added a subscriber: User-Daniel.Dec 6 2016, 6:11 PM
WMDE-leszek subscribed.Dec 7 2016, 4:37 PM
WMDE-leszek triaged this task as Medium priority.Dec 7 2016, 4:40 PM
WMDE-leszek removed Ladsgroup as the assignee of this task.Dec 8 2016, 5:50 PM
• Aleksey_WMDE claimed this task.Dec 12 2016, 11:11 AM
• Aleksey_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
• Aleksey_WMDE mentioned this in rEWLE51bc7f8359a0: Restructured SpecialNewLexeme tests.Dec 27 2016, 2:05 PM
• Aleksey_WMDE mentioned this in rEWLE4f2078e17012: Restructured SpecialNewLexeme tests.Dec 27 2016, 2:15 PM
• Aleksey_WMDE mentioned this in rEWLE3d1cf3024ec6: Restructured SpecialNewLexeme tests.Dec 27 2016, 2:18 PM
• Aleksey_WMDE mentioned this in rEWLEf1ad30d5d5fe: Restructured SpecialNewLexeme tests.Dec 27 2016, 2:54 PM
WMDE-leszek renamed this task from Refactor SpecialNewEntity so it can be extended to SpecialNewLexme to Refactor SpecialNewEntity so it can be extended to SpecialNewLexeme.Dec 29 2016, 2:06 PM
gerritbot subscribed.Dec 30 2016, 2:11 PM

Change 329349 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
Reduced number of fields for some Special pages and added constructor DI

https://gerrit.wikimedia.org/r/329349

gerritbot added a project: Patch-For-Review.Dec 30 2016, 2:11 PM
gerritbot added a comment.Dec 30 2016, 3:01 PM

Change 329338 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
Restructured and added SpecialNewLexeme tests

https://gerrit.wikimedia.org/r/329338

• Aleksey_WMDE mentioned this in rEWLE56a461f76b54: Restructured and added SpecialNewLexeme tests.Dec 30 2016, 3:02 PM
• Aleksey_WMDE mentioned this in rEWLEf4dafa9a7b01: Restructured and added SpecialNewLexeme tests.Dec 30 2016, 3:29 PM
WMDE-leszek moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Jan 2 2017, 10:46 AM
• Aleksey_WMDE mentioned this in rEWLE4762e94951d3: Restructured and added SpecialNewLexeme tests.Jan 3 2017, 12:45 PM
gerritbot added a comment.Jan 3 2017, 1:19 PM

Change 329349 merged by jenkins-bot:
Reduced number of fields for some Special pages and added constructor DI

https://gerrit.wikimedia.org/r/329349

gerritbot added a comment.Jan 3 2017, 3:59 PM

Change 330231 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
SpecialNewLexeme refactoring and addition of input validation

https://gerrit.wikimedia.org/r/330231

• Aleksey_WMDE mentioned this in rEWLE72f0a048cce5: SpecialNewLexeme refactoring and addition of input validation.Jan 3 2017, 3:59 PM
• Aleksey_WMDE mentioned this in rEWLE898e24b79694: SpecialNewLexeme refactoring and addition of input validation.Jan 3 2017, 6:27 PM
• Aleksey_WMDE mentioned this in rEWLEc8c0e9be513b: SpecialNewLexeme refactoring and addition of input validation.Jan 4 2017, 10:07 AM
gerritbot added a comment.Jan 4 2017, 10:25 AM

Change 329338 merged by jenkins-bot:
Restructured and added SpecialNewLexeme tests

https://gerrit.wikimedia.org/r/329338

gerritbot added a comment.Jan 4 2017, 1:21 PM

Change 330405 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
Added item reference field type

https://gerrit.wikimedia.org/r/330405

gerritbot added a comment.Jan 4 2017, 1:36 PM

Change 330407 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
SpecialNewLexeme now uses HTMLItemReferenceField

https://gerrit.wikimedia.org/r/330407

• Aleksey_WMDE mentioned this in rEWLE6fb2e925c344: SpecialNewLexeme now uses HTMLItemReferenceField.Jan 4 2017, 1:36 PM
gerritbot added a comment.Jan 5 2017, 2:01 PM

Change 330405 merged by jenkins-bot:
Added item reference field type

https://gerrit.wikimedia.org/r/330405

• Aleksey_WMDE mentioned this in rEWLE34f9a247091f: SpecialNewLexeme refactoring and addition of input validation.Jan 6 2017, 1:09 PM
• Aleksey_WMDE mentioned this in rEWLE4feb1ffebdfd: SpecialNewLexeme refactoring and addition of input validation.Jan 6 2017, 1:11 PM
• Aleksey_WMDE mentioned this in rEWLEf77a93f5d059: SpecialNewLexeme refactoring and addition of input validation.Jan 6 2017, 1:25 PM
WMDE-leszek mentioned this in rEWLE04510f5bb421: SpecialNewLexeme now uses HTMLItemReferenceField.Jan 6 2017, 1:41 PM
WMDE-leszek mentioned this in rEWLEdc80b7282dcc: SpecialNewLexeme now uses HTMLItemReferenceField.
• Aleksey_WMDE mentioned this in rEWLEf152c7052a5c: SpecialNewLexeme refactoring and addition of input validation.Jan 6 2017, 4:27 PM
gerritbot added a comment.Jan 6 2017, 4:45 PM

Change 330231 merged by jenkins-bot:
SpecialNewLexeme refactoring and addition of input validation

https://gerrit.wikimedia.org/r/330231

• Aleksey_WMDE mentioned this in rEWLE2fb81ef8e023: SpecialNewLexeme now uses HTMLItemReferenceField.Jan 6 2017, 4:56 PM
gerritbot added a comment.Jan 6 2017, 5:08 PM

Change 330407 merged by Aleksey Bekh-Ivanov (WMDE):
SpecialNewLexeme now uses HTMLItemReferenceField

https://gerrit.wikimedia.org/r/330407

Ladsgroup moved this task from Later to Monitor on the User-Ladsgroup board.Jan 6 2017, 8:16 PM
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Jan 11 2017, 4:31 PM
WMDE-leszek closed this task as Resolved.Jan 30 2017, 8:35 AM
Aklapper edited subscribers, added: daniel; removed: User-Daniel.May 17 2023, 7:28 AM
Maintenance_bot removed a project: Patch-For-Review.May 17 2023, 7:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL