Page MenuHomePhabricator

Toggling icon does not show on slow connections even when sections can be expanded
Closed, DeclinedPublic

Description

Using GPRS visit any website.
Now enter the URL https://en.m.wikipedia.beta.wmflabs.org/wiki/Black-body_radiation
Hit abort as soon as the page rendered (ie. you see something/first paint).

  • the page shows collapsed and sections open when you click on them
  • Toggling chevron is not visible but edit icon is.

cc @Nirzar is this worth fixing?

Event Timeline

Jdlrobson created this task.Nov 8 2016, 9:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2016, 9:54 AM

I think it makes sense to load the icons as well, it will be confusing that they might be collapsible afterwards.

ovasileva triaged this task as Normal priority.Nov 9 2016, 5:23 PM
ovasileva moved this task from Incoming to Design on the Readers-Web-Backlog board.

@Nirzar, note that currently while the toggling code is loading, we cannot collapse a section once it's been expanded. If we show the down icon when the section is collapsed, then should we hide it when the section is expanded?

@bmansurov i didn't understand. if toggling code is loading how can the section be expanded?

@Nirzar, we implemented the solution #1 from T147338. That allows to start the page with sections collapsed. In case toggling code doesn't load, the user won't get stuck with un-expandable sections. Once the toggling code has loaded, that temporary toggling code will be removed.

for now... let's not fix it.

but we can look into using unicode or data uri for this. we have temporary code for expansion but the icon is also part of expansion so we need low weight solution for that also.

for example- this is a data URI for chevron @2x it's a raster but we can use it. it's pretty small.

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABQAAAAOBAMAAADd6iHDAAAAElBMVEUAAACboaeaoKidoamboqqaoKeC8OQbAAAABXRSTlMAgPVBITk2b6sAAABJSURBVAjXTcixDcAgFANRo2QAGiZA6SMmYAWQ/v6rAOcGNz493eu+V0rV2bLK/E8931CJCsZQis0bIwsGBRth0AyaQTNoBs3gAo5WDChvtL4yAAAAAElFTkSuQmCC

Jdlrobson closed this task as Declined.Jun 21 2017, 1:12 AM

I think this is fine.

Several reasons:

  • Age of bug
  • It gives a good indication to the user that the feature is not ready and not completely usable.
  • The arrow icon is currently not loaded in render blocking styles, to address this it would need to be which would increase bytes and possibly first paint
  • If we were to add it, we'd need to add logic in inline JS that updates the toggle icon when a section is opened
    • and also when JS does load identifies current state.

I don't think any of this complexity is worth it.