Page MenuHomePhabricator

The Intuition project translatable messages don't show $1 as an insertable
Closed, ResolvedPublic

Description

This is similar to T150238: The CopyPatrol project translatable messages don't show $1 as an insertable, but for the Intuition project.

I'd expect $1 to be insertable.

These variables are already used in MediaWiki and several other translatewiki.net projects, so it should be easy to adapt them to Intuition.

Event Timeline

@Amire80,
Could you clarify what you mean by insertable?
Thanks!
MtDu

"Insertable" in the Translate extension is a string that you can insert by clicking or tapping a button on the screen, instead of typing with your fingers on the keyboard. This is usually done for technical parts of translatable strings that are often repeated, such as parameters, {{GENDER}}, {{PLURAL}}, etc. If you translate a string with "$1" in MediaWiki core, for example, you'll see a button that says "$1" in the editing area. The same is needed for Intuition. It's fairly simple code that can be copied from the configuration of the MediaWiki project.

@Amire80 If I'm currently waiting approval for a task, do you mind if I go ahead and do this and then claim it on the GCI page?
Thanks for mentoring!
MtDu

I certainly don't mind. Questions about GCI process are better directed to @Aklapper though :)

Change 325343 had a related patch set uploaded (by MtDu):
Support $1 as insertables in the Intuition Project

https://gerrit.wikimedia.org/r/325343

Alrighty then. I'll claim it here. The patch has been pushed. :)

I just added the insert able suggester to each of the yml files.

@Amire80 Did you see my patch? Please take a look when you get a chance.
Thanks!
Justin

@Amire80 Did you see my patch? Please take a look when you get a chance.
Thanks!
Justin

The patch is getting merged now. @Amire80 Please accept on GCI when you can. Sorry for the confusion!
Thanks!
MtDu

Change 325343 merged by jenkins-bot:
Support $1 as insertables in the Intuition Project

https://gerrit.wikimedia.org/r/325343