Page MenuHomePhabricator

The lib.reviews project should support %s as insertable parameters
Closed, ResolvedPublic

Description

The lib.reviews project uses %s as the parameter format. It should be supported as insertables. This is similar to $1 in MediaWiki and other projects, and the configuration is very similar, so marking it as good first task.

For an example see the Wikipedia Android app project.

Event Timeline

Amire80 renamed this task from The lib.reviews project should support %1 as insertable parameters to The lib.reviews project should support %s as insertable parameters.Nov 8 2016, 11:06 AM
Amire80 updated the task description. (Show Details)

@Amire80: Could you please explain where to find "the lib.reviews project", where to read about "parameter formats", where to find the "Wikipedia Android app" so a new contributor would now where to get started? Thanks!

Change 326186 had a related patch set uploaded (by MtDu):
Support %s as insertable parameters in the lib.reviews project

https://gerrit.wikimedia.org/r/326186

Aklapper removed a project: Google-Code-In-2016.

Thanks a lot for the patch!
(I have to remove this from #Google-Code-in though, due to section 4.2c of the contest rules.)

Change 326186 merged by jenkins-bot:
Support %s and %1$s as insertable parameters in the lib.reviews project

https://gerrit.wikimedia.org/r/326186

Patch has been merged, thus closing as resolved!
Thanks!