Port Flow to new core dependency injection container
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	• Mattflaschen-WMF
	Nov 9 2016, 6:41 PM

Description

Flow started using dependency injection (DI) before core. However, core now has a dependency injection component (MediaWikiServices), so we should port Flow to use it.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T150350 Port Flow to new core dependency injection container
		Open		None	T170330 Replace Flow DI (pimple) with MediaWikiServices

Event Timeline

• Mattflaschen-WMF created this task.Nov 9 2016, 6:41 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 9 2016, 6:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• jmatazzoni moved this task from Untriaged to Flow Holding Area on the Collaboration-Team-Triage board.Nov 18 2016, 12:37 AM

Aklapper removed a project: Collaboration-Team-Triage.Oct 12 2019, 4:11 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 12 2019, 4:11 AM

DannyS712 mentioned this in T247623: Create #dependency-injection.Mar 13 2020, 7:36 PM

I started working on this last week because it'll let us get rid of the pimple dependency.

I feel like I've reviewed most of the relevant code, I think the biggest problem right now is PurgeAction, which destroys the entire container, installs a fake memcached, queries a bunch of stuff, then examines the memcache keys that would have been set, and uses those as a list of keys to purge.

Patches: https://gerrit.wikimedia.org/r/q/topic:%22remove-pimple%22+(status:open%20OR%20status:merged)

DannyS712 added a project: Dependency injection.Mar 20 2020, 5:06 PM

In T150350#5978188, @Legoktm wrote:

I feel like I've reviewed most of the relevant code, I think the biggest problem right now is PurgeAction, which destroys the entire container, installs a fake memcached, queries a bunch of stuff, then examines the memcache keys that would have been set, and uses those as a list of keys to purge.

I'm giving up for now because I don't want to figure out how to fix this.

Legoktm removed Legoktm as the assignee of this task.May 22 2020, 1:09 AM

Jdforrester-WMF added a subtask: T170330: Replace Flow DI (pimple) with MediaWikiServices.Apr 2 2021, 10:36 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:59 PM

fyi: PurgeAction has been removed 98570f4b74f4034b726aed2d707e681c569e64c3

KStoller-WMF mentioned this in T332022: [Epic] Undeploying StructuredDiscussions (Flow).May 3 2023, 3:35 AM

KStoller-WMF mentioned this in T346108: [EPIC] IP Masking: StructuredDiscussions (Flow)/LiquidThreads Community discussion.Sep 11 2023, 10:25 PM