Page MenuHomePhabricator
Create Task
Maniphest T150383

Diff not implemented for Flow\Content\BoardContent
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Here is a talk page diff:

https://fr.wikiquote.org/w/index.php?diff=246302

and here it is with mobile diff:

https://fr.wikiquote.org/wiki/Sp%C3%A9cial:MobileDiff/246302

Related Objects

Event Timeline

Matanya created this task.Nov 9 2016, 11:06 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 9 2016, 11:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a project: Mobile.Nov 10 2016, 1:43 PM

What does "broken" mean exactly?
I even get an exception on that page:
[WCR5bgpAMEcAAB-DrM8AAABQ] 2016-11-10 13:43:10: Erreur fatale de type « MWException »

Peachey88 added a project: Wikimedia-production-error.Nov 10 2016, 2:04 PM
Reedy subscribed.Nov 10 2016, 2:07 PM
2016-11-10 13:43:10 [WCR5bgpAMEcAAB-DrM8AAABQ] mw1236 frwikiquote 1.29.0-wmf.2 exception ERROR: [WCR5bgpAMEcAAB-DrM8AAABQ] /wiki/Sp%C3%A9cial:MobileDiff/246302   MWException from line 841 of /srv/mediawiki/php-1.29.0-wmf.2/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this. {"exception_id":"WCR5bgpAMEcAAB-DrM8AAABQ"} 
[Exception MWException] (/srv/mediawiki/php-1.29.0-wmf.2/includes/diff/DifferenceEngine.php:841) Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.
  #0 /srv/mediawiki/php-1.29.0-wmf.2/includes/diff/DifferenceEngine.php(783): DifferenceEngine->generateContentDiffBody(Flow\Content\BoardContent, Flow\Content\BoardContent)
  #1 /srv/mediawiki/php-1.29.0-wmf.2/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(243): DifferenceEngine->getDiffBody()
  #2 /srv/mediawiki/php-1.29.0-wmf.2/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(136): SpecialMobileDiff->showDiff()
  #3 /srv/mediawiki/php-1.29.0-wmf.2/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(53): SpecialMobileDiff->executeWhenAvailable(string)
  #4 /srv/mediawiki/php-1.29.0-wmf.2/includes/specialpage/SpecialPage.php(522): MobileSpecialPage->execute(string)
  #5 /srv/mediawiki/php-1.29.0-wmf.2/includes/specialpage/SpecialPageFactory.php(584): SpecialPage->run(string)
  #6 /srv/mediawiki/php-1.29.0-wmf.2/includes/MediaWiki.php(283): SpecialPageFactory::executePath(Title, RequestContext)
  #7 /srv/mediawiki/php-1.29.0-wmf.2/includes/MediaWiki.php(861): MediaWiki->performRequest()
  #8 /srv/mediawiki/php-1.29.0-wmf.2/includes/MediaWiki.php(522): MediaWiki->main()
  #9 /srv/mediawiki/php-1.29.0-wmf.2/index.php(43): MediaWiki->run()
  #10 /srv/mediawiki/w/index.php(3): include(string)
  #11 {main}
Reedy renamed this task from mobile diff broken on flow pages to Diff not implemented for Flow\Content\BoardContent.Nov 10 2016, 2:07 PM
Reedy moved this task from Needs triage to Triaged on the Mobile board.
• Mattflaschen-WMF subscribed.Nov 15 2016, 6:57 PM

Is this link exposed anywhere, or did you get it by modifying the URL manually?

• Mattflaschen-WMF added a comment.Nov 15 2016, 6:57 PM

In the short term, we should make sure we're not linking to it anywhere.

Etonkovidova subscribed.Nov 16 2016, 11:47 PM

For future testing (after the fix):

  • wikitext pages do not produce errors for Special:MobileDiff (at least I cannot find an instance)
  • the first revision (rev_id in revision table) does not produce the error; all subsequent rev_id (s) will display the error.
  • testwiki displays the above bug trace on the page
• jmatazzoni moved this task from Untriaged to Flow Holding Area on the Collaboration-Team-Triage board.Nov 18 2016, 12:38 AM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jan 10 2017, 10:55 PM
Krinkle merged a task: T110679: MediaWiki error for deleted Flow board, when clicking 'Show changes'.Sep 12 2018, 2:28 AM
Krinkle added subscribers: Luke081515, Liuxinyu970226, Krenair.
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 12 2018, 2:28 AM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 12 2018, 2:30 AM
Krinkle subscribed.

Still seen.

Sample from Logstash
[{exception_id}] {exception_url}   MWException from line 895 of /srv/mediawiki/php-1.32.0-wmf.16/includes/diff/DifferenceEngine.php: 
Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.

type: mediawiki
level: ERROR
channel: exception
reqId: W3bdxApAIDcAAIdWPDsAAACA
http_method: GET


#0 /srv/mediawiki/php-1.32.0-wmf.16/includes/diff/DifferenceEngine.php(803): DifferenceEngine->generateContentDiffBody(Flow\Content\BoardContent, Flow\Content\BoardContent)
#1 /srv/mediawiki/php-1.32.0-wmf.16/includes/api/ApiComparePages.php(138): DifferenceEngine->getDiffBody()
#2 /srv/mediawiki/php-1.32.0-wmf.16/includes/api/ApiMain.php(1579): ApiComparePages->execute()
#3 /srv/mediawiki/php-1.32.0-wmf.16/includes/api/ApiMain.php(533): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.32.0-wmf.16/includes/api/ApiMain.php(504): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.32.0-wmf.16/api.php(83): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)
#7 {main}

URL:

https://www.mediawiki.org/w/api.php?action=compare&format=json&prop=ids%7Ctitle&fromrev=2528291&torelative=prev

Krinkle removed projects: Mobile, Collaboration-Team-Triage.Sep 12 2018, 2:30 AM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 1:05 AM
kostajh edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.Nov 7 2018, 7:45 PM
kostajh subscribed.

This should be solved by T206090

kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 7 2018, 7:45 PM
Etonkovidova moved this task from QA to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 20 2018, 5:28 PM

The issue does not seem to be fixed - re-checked in wmf.4 and also checked T206090: Certain Special:MobileDiff urls fatal with "Bad value for parameter $old: must be a TextContent" which doesn't seem to be actually fixed either. Special:Mobilediff will display 'Error' page (as in per links in the task) for any revision of any flow-based page.

kostajh added a comment.Nov 20 2018, 5:33 PM

@Etonkovidova the fix was to display an error but not totally break the page display by throwing an uncaught exception. Before, if you visited those URLs, you'd get a fatal error from PHP. Since diff isn't implemented, we return an error but don't prevent the rest of the page from loading.

Etonkovidova closed this task as Resolved.Nov 20 2018, 6:26 PM
Etonkovidova claimed this task.

Thanks, @kostajh - Resolved then.

Liuxinyu970226 unsubscribed.Nov 21 2018, 2:16 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits