Page MenuHomePhabricator

[minor] Blue border appears on side rail toggle after clicking
Closed, InvalidPublic

Description

  1. Click on a Permalink for any topic on Flow board.
  2. Then, click at the icon "Read at full width" arrow icon

The icon will display a blue outline which goes away only when focus is changed.

Screen Shot 2016-11-09 at 12.57.38 PM.png (106×1 px, 18 KB)

Event Timeline

Catrope renamed this task from [minor] oo-ui-iconElement-icon oo-ui-icon-topic-collapse has a blue border to [minor] Blue border appears on side rail toggle after clicking.Nov 10 2016, 1:48 AM
Catrope subscribed.

Looks like it's probably an issue with OOUI. We probably move the button before mouseup, but button widgets should tolerate that.

The plot thickens: this is a pre-wmf.3 regression, only in master and not on mw.org. Probably caused by yesterday's OOUI release.

Hmm, well there are three possible outcomes:

  1. Accept it. If you look at ButtonWidget (icon) that has been the default behaviour for quite a while now, as it aims at improving the accessibility for keyboard-only users.
  2. If we see this as problematic visual impact (I see it right now more as a trade-off) we should discuss focus states of those icons
  3. Seen as problematic and magically make it work for keyboard-users only (not feasible IMHO)

https://gerrit.wikimedia.org/r/322376 is somewhat related, although it doesn't change the outcome described.

'Browse topics' also has unnecessary blue outline.

Screen Shot 2016-11-15 at 2.23.31 PM.png (360×346 px, 24 KB)

Thanks for pointing this out @Etonkovidova – but as I said three comments above, the question is, is it really “unnecessary”?

@Volker_E - well, the issue is filed as a minor issue. The blue outline does not interfere with any functionality; does not have a big negative visual impact. However, especially since it's a regression, I think it is a unnecessary addition.