SiteMatrix should use short array syntax and shorter lines
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Nov 10 2016, 1:09 PM

Description

SiteMatrix is a bit legacy and fails a couple PHP CodeSniffer rules:

Generic.Arrays.DisallowLongArraySyntax.Found
Generic.Files.LineLength.TooLong

Might want to shorten the lines and switch to the Zend short array syntax.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Make SiteMatrix fit coding standards	mediawiki/extensions/SiteMatrix	master	+70 -179
Make SiteMatrix fit coding standards (part 3)	mediawiki/extensions/SiteMatrix	master	+56 -41
Make SiteMatrix fit coding standards (part 4)	mediawiki/extensions/SiteMatrix	master	+0 -0
Make SiteMatrix fit coding standards (part 2)	mediawiki/extensions/SiteMatrix	master	+32 -35
Add composer tests / parallel lint / PHPcs	mediawiki/extensions/SiteMatrix	master	+31 -1
[SiteMatrix] add composer test	integration/config	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: E515: Code Review Office Hours

Event Timeline

hashar created this task.Nov 10 2016, 1:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2016, 1:09 PM

Change 320767 had a related patch set uploaded (by Hashar):
Add composer tests / parallel lint / PHPcs

https://gerrit.wikimedia.org/r/320767

Change 320768 had a related patch set uploaded (by Hashar):
[SiteMatrix] add composer test

https://gerrit.wikimedia.org/r/320768

Change 320768 merged by jenkins-bot:
[SiteMatrix] add composer test

https://gerrit.wikimedia.org/r/320768

Change 320767 merged by jenkins-bot:
Add composer tests / parallel lint / PHPcs

https://gerrit.wikimedia.org/r/320767

hashar removed a project: Patch-For-Review.Nov 10 2016, 1:17 PM

hashar added a project: good first task.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptNov 10 2016, 1:17 PM

phpcs pass just fine now, both rules have severity=0 which skip them.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)).Nov 10 2016, 2:00 PM

Change 340734 had a related patch set uploaded (by EddieGP):
[mediawiki/extensions/SiteMatrix] Make SiteMatrix fit coding standards

https://gerrit.wikimedia.org/r/340734

gerritbot added a project: Patch-For-Review.Mar 2 2017, 12:52 PM

EddieGP claimed this task.Mar 2 2017, 12:54 PM

EddieGP mentioned this in E515: Code Review Office Hours.Mar 2 2017, 6:11 PM

Change 340734 merged by EddieGP:
[mediawiki/extensions/SiteMatrix] Make SiteMatrix fit coding standards

https://gerrit.wikimedia.org/r/340734

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 2 2017, 10:00 PM

Change 340915 had a related patch set uploaded (by EddieGP):
[mediawiki/extensions/SiteMatrix] Make SiteMatrix fit coding standards (part 2)

https://gerrit.wikimedia.org/r/340915

Change 340915 merged by Krinkle:
[mediawiki/extensions/SiteMatrix] Make SiteMatrix fit coding standards (part 2)

https://gerrit.wikimedia.org/r/340915

Change 340964 had a related patch set uploaded (by eddie):
[mediawiki/extensions/SiteMatrix] Make SiteMatrix fit coding standards (part 3)

https://gerrit.wikimedia.org/r/340964

Change 340965 had a related patch set uploaded (by eddie):
[mediawiki/extensions/SiteMatrix] Make SiteMatrix fit coding standards (part 4)

https://gerrit.wikimedia.org/r/340965

Change 340965 abandoned by Hashar:
Make SiteMatrix fit coding standards (part 4)

Reason:
all code has been merged in https://gerrit.wikimedia.org/r/#/c/340964/ :)

https://gerrit.wikimedia.org/r/340965

Well done :]

Change 340964 merged by jenkins-bot:
[mediawiki/extensions/SiteMatrix] Make SiteMatrix fit coding standards (part 3)