Page MenuHomePhabricator
Create Task
Maniphest T150557

[Regression wmf.2] Cursor stays at the beginning of comment node instead of moving to the end of it after adding
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Place your cursor at the end of a line

  1. Insert a comment node

Observed Result:
Cursor is staying the at the beginning of comment node, in the middle of the text and comment node.
Previously it used to go the end of the comment node .

Screen Shot 2016-11-11 at 11.12.24 PM.png (158×440 px, 16 KB)

Details

SubjectRepoBranchLines +/-
ui.CommentInspector: Select placeholder comment node while editingVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Nov 11 2016, 11:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2016, 11:12 PM
DLynch added subscribers: dchan, DLynch.Nov 14 2016, 5:43 PM

I initially thought this might be c3d3d29, which changed the preview. However, at that point it was still selecting the new comment node rather than placing the cursor on either side of it.

Bisect indicates that the selection behavior changed in 7a4de14 by @dchan.

gerritbot subscribed.Nov 14 2016, 5:49 PM

Change 321399 had a related patch set uploaded (by DLynch):
ui.CommentInspector: Select placeholder comment node while editing

https://gerrit.wikimedia.org/r/321399

gerritbot added a project: Patch-For-Review.Nov 14 2016, 5:49 PM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.Nov 14 2016, 7:10 PM
Jdforrester-WMF assigned this task to DLynch.Nov 14 2016, 7:17 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
gerritbot added a comment.Nov 14 2016, 7:38 PM

Change 321399 merged by jenkins-bot:
ui.CommentInspector: Select placeholder comment node while editing

https://gerrit.wikimedia.org/r/321399

gerritbot added a comment.Nov 14 2016, 7:39 PM

Change 321475 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (f0c7873)

https://gerrit.wikimedia.org/r/321475

Jdforrester-WMF closed this task as Resolved.Nov 14 2016, 10:27 PM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)); removed Patch-For-Review.
Ryasmeen added a project: Verified.Nov 17 2016, 9:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL