Page MenuHomePhabricator

Handle abusefilter warnings and errors
Closed, ResolvedPublic1 Estimated Story Points

Description

As a followup to the parent task, the Wikidata description editing client and workflow needs to take potential abusefilter warnings and errors into account.

Steps to verify once the UI for that has been implemented:
For testing I have been using the Wikidata sandbox item https://www.wikidata.org/wiki/Q4115189,
which is linked on enwiki to https://en.wikipedia.org/wiki/Wikipedia:Wikidata/Wikidata_Sandbox.
The wikidata item has links to other wikis (towards the bottom of the page). E.g. Wikipedia:Wikidata/Wikidata-Spielwiese for testing German.

  1. Open page Wikipedia:Wikidata/Wikidata_Sandbox
  2. Tap the first edit pencil
  3. Tap "Edit title description"
  4. On the new screen make a change to the description that triggers an abusefilter.

There are at least two different types, Warn and Disallow, possibly more (see https://www.wikidata.org/wiki/Special:AbuseFilter).

They are triggered by adding undesirable word to the description, like swear words, self promotion, etc.

  • To trigger the Disallow filter add the string "wikipedia page in need of description" (Filter 75).
  • Still need a good way to trigger a warning, just by editing a description.

Event Timeline

Change 320965 had a related patch set uploaded (by BearND):
Handle abusefilters in Wikidata description editing

https://gerrit.wikimedia.org/r/320965

Change 320965 merged by jenkins-bot:
Handle abusefilters in Wikidata description editing

https://gerrit.wikimedia.org/r/320965

Change 325519 had a related patch set uploaded (by BearND):
Add UI for abusefilter cases in description editing

https://gerrit.wikimedia.org/r/325519

Looks like there's no special card for hooking up abusefilters in the UI. The above patch addresses that. Until that is merged the abusefilter cases don't work correctly in the alpha app.

Change 325519 merged by jenkins-bot:
Add UI for abusefilter cases in description editing

https://gerrit.wikimedia.org/r/325519

RHo subscribed.

Two minor things:

  • The bold tag is not working but showing up as "<b>" and "</b>" within the message. It isn't strictly necessary for 'Warning' to be bolded so recommend just removing emboldening.

Screenshot_1485880804.png (1×1 px, 164 KB)

  • When I first tried to prompt the abuse filter with "shit", this was allowed... is this expected? Just wondering to what extent the sensitivity of abuse is for QA.

Screenshot_1485880791.png (1×1 px, 912 KB)

  • When I first tried to prompt the abuse filter with "shit", this was allowed... is this expected? Just wondering to what extent the sensitivity of abuse is for QA.

Lol, it looks like the AbuseFilter is fairly permissive on Wikidata: https://www.wikidata.org/w/index.php?title=Q4115189&type=revision&diff=440167668&oldid=440167469

Settings will vary by wiki.

Change 335262 had a related patch set uploaded (by Mholloway):
Update abuse filter result handling

https://gerrit.wikimedia.org/r/335262

@RHo Adding something that looks to a regex filter like a spambot link (e.g., http://s-e-x) should do the trick without fail.

Change 335262 abandoned by Mholloway:
Update abuse filter result handling

Reason:
The special logic for handling abuse filter results is appropriate.

https://gerrit.wikimedia.org/r/335262

No worries regarding the abuse filter logic. Can the <b> tags be removed from the error message though?

@RHo In the current alpha, we should be properly handling the html of the abusefilter message, so it will appear like this:

device-2017-02-02-170319.png (2×1 px, 199 KB)

No worries regarding the abuse filter logic. Can the <b> tags be removed from the error message though?

This should be fixed by @Dbrant's patch (I just double-checked and it looks like it was).

@RHo Adding something that looks to a regex filter like a spambot link (e.g., http://s-e-x) should do the trick without fail.

Also, for the record, I think this actually triggers SpamBlacklist, which is distinct from AbuseFilter (and produces a slightly different error format). Sorry to anyone misled by the above!