Changes have been moved from GitHub to Gerrit in T149674: https://gerrit.wikimedia.org/r/319866 but needs to be adjusted to make the CI pass.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • DannyH | T121469 Improve diff compare screen | |||
| Resolved | thiemowmde | T139603 Show text changes when moving text chunks (#2) | |||
| Resolved | None | T146781 Show changes in moved text chunks (C++) | |||
| Resolved | Tobi_WMDE_SW | T150740 Make CI pass for wikidiff2 changes |
Event Timeline
Comment Actions
Change 319866 had a related patch set uploaded (by Tobias Gritschacher):
[WIP] Extend WikiDiff2 to show changes inside moved paragraphes
Comment Actions
CI passes on jenkins.
- the code compiles for PHP and HHVM
- for PHP the test run and pass
- for HHVM tests are not executed
When I run make test on my local machine after compiling for HHVM the tests fail due to some missing configuration. Since running this on master gives the same errors it seems, running the tests on HVVM is not intended.
Comment Actions
Change 319866 had a related patch set uploaded (by Jkroll):
[WIP] Extend WikiDiff2 to show changes inside moved paragraphs This is the moved-line-diff branch by @jkroll copied from GitHub that was started to extend WikiDiff2 with options to make changes in moved paragraphs visible.
Comment Actions
Change 356582 had a related patch set uploaded (by Jkroll; owner: MaxSem):
[mediawiki/php/wikidiff2@master] [WIP] Extend WikiDiff2 to show changes inside moved paragraphs - better change/add/delete distinction Improve handling of change/add/delete ops in diff engine so Change 319866 gets a chance to run.
Comment Actions
Change 319866 had a related patch set uploaded (by Jkroll; owner: WMDE-Fisch):
[mediawiki/php/wikidiff2@master] Extend WikiDiff2 to show changes inside moved paragraphs
Comment Actions
Change 356582 had a related patch set uploaded (by Jkroll; owner: MaxSem):
[mediawiki/php/wikidiff2@master] Better change/add/delete distinction for DiffOps
Comment Actions
Change 356582 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Better change/add/delete distinction for DiffOps
Comment Actions
Change 319866 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Extend WikiDiff2 to show changes inside moved paragraphs