Page MenuHomePhabricator
Create Task
Maniphest T150743

Investigate SVG default language behavior on non-English wikis for Thumbor
Closed, ResolvedPublic
Actions

Description

This has come to light in the logs because Thumbor doesn't care when the language in the lang parameter is the same as the wiki's, but Mediawiki treats this as an invalid request:

Nov 15 11:29:51 ms-fe1001 proxy-server: HTTP status code mismatch. Mediawiki: 400 Thumbor: 404 URL: http://upload.wikimedia.org/wikipedia/fr/thumb/1/1d/Logo_Naruto.svg/langfr-986px-Logo_Naruto.svg.png

Which makes me wonder if Mediawiki defaults to using the wiki's default language when no lang parameter is provided. Which Thumbor doesn't currently do, leaving the system's default locale (english).

Related Objects
Search...

Event Timeline

• Gilles created this task.Nov 15 2016, 11:40 AM
• Gilles raised the priority of this task from Medium to High.Nov 15 2016, 12:30 PM
• Gilles lowered the priority of this task from High to Medium.Nov 17 2016, 8:46 AM
• Gilles moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.Nov 17 2016, 10:06 AM
• Gilles closed this task as Resolved.Nov 21 2016, 1:22 PM

This works fine: https://upload.wikimedia.org/wikipedia/fr/thumb/4/45/Speech_bubbles_test2.svg/langfr-120px-Speech_bubbles_test2.svg.png

I think that the Mediawiki error happening for the Naruto file is incorrect. This file doesn't exist: https://fr.wikipedia.org/wiki/Fichier:Logo_Naruto.svg which means that Thumbor's error is more accurate.

I've also checked and the default thumb language is just english, it's not the wiki's language. Which means that Thumbor doesn't need to do anything more than it currently does.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL