I can only click on the triangle itself, not the space around it:
Description
Details
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/core | master | +266 -98 | Update OOUI to v0.30.0 | |
oojs/ui | master | +8 -6 | Apex theme: Align functionality of ComboBoxInputWidget with WikimediaUI theme |
Event Timeline
Change 480306 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Apex theme: Align functionality of ComboBoxInputWidget with WikimediaUI theme
I think there's an argument for not using the gradient styling on the button. DropdownWidgets in Apex have hover styling, are clickable, but have no shading:
wmui | apex |
Unlike in WMUI where dropdowns are styled the same as buttons (light grey background). Given that this inconsistency already exists between the skins, I think it's best to make the widget consistent within the skin.
From gerrit:
James F:
This is a pretty major deviation from the design concept of Apex. The whole point is that this is understated and lightweight.
Volker:
Lightweight? With those clumsy buttons? *tongueincheek*
The SelectFileWidget features a framed button. ComboboxInputWidget is featuring a framed button as it needs to separate the interactive area from the input – they are both handling clicks with different results, so it makes sense to visually separate them.
Do I understand you correctly that a frameless button would be the expected outcome for you?
James F:
Yes
they are both handling clicks with different results
The sounds like a reasonable argument for visual separation though. In general I'm not going to have a strong opinion about Apex changes :)
Exactly the last comment. My take here was, this (emphasized in red rectangular)
is the dropdown part. I don't care too much any direction, let's just get to a decision. Especially as the combination Apex/ComboBoxInputWidget is very rare.
Change 480306 merged by jenkins-bot:
[oojs/ui@master] Apex theme: Align functionality of ComboBoxInputWidget with WikimediaUI theme
Change 481239 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.0