Regression: FOUC for tablet users
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

T126825 fixed the FOUC on mobile however if you visit https://en.m.wikipedia.org/wiki/Los_Angeles_Lakers on a desktop device and scroll down.
The sections are initially collapsed but expand as soon as the JS loads.

e.g. loading the above on an (emulated) average 2G connection in Chrome (54.0.2840.98) looks as follows:

AC

Test that there is no FOUC on mobile
Test that there is no FOUC on tablet

Test Plan

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Barack_Obama on a tablet device and notice that sections are expanded by default (as opposed to collapsed and then expanded when the page finishes loading).

Details

	Subject	Repo	Branch	Lines +/-
	Avoid a flash of unstyled content on most tablet devices	mediawiki/extensions/MobileFrontend	master	+10 -0

Customize query in gerrit

Related Objects

Mentioned Here: T126825: Sections on mobile views jumps around after load (FOUC)

Event Timeline

Jdlrobson created this task.Nov 16 2016, 10:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2016, 10:06 AM

Since this task was signed off during this sprint I've added it to this sprint as I don't think the work can be deemed complete.

Not sure whether it's appropriate to reopen T150839 in this case given T150839 remains fixed and this is a regression.

• jhobs triaged this task as High priority.Nov 16 2016, 5:46 PM

• jhobs moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.

phuedx updated the task description. (Show Details)Nov 17 2016, 10:03 AM

phuedx updated the task description. (Show Details)

Jdlrobson claimed this task.Nov 17 2016, 11:27 AM

Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-85-💩 board.

Change 322081 had a related patch set uploaded (by Jdlrobson):
Avoid a flash of unstyled content on most tablet devices

https://gerrit.wikimedia.org/r/322081

gerritbot added a project: Patch-For-Review.Nov 17 2016, 11:32 AM

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-85-💩 board.Nov 17 2016, 11:32 AM

• bmansurov moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-85-💩 board.Nov 18 2016, 12:03 AM

Jdlrobson moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-85-💩 board.Nov 18 2016, 9:36 AM

ovasileva added a project: Reading-Web-Sprint-86-🔪🦃.Nov 21 2016, 5:05 PM

MBinder_WMF set the point value for this task to 3.Nov 21 2016, 5:09 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 5:12 PM

• bmansurov updated the task description. (Show Details)Nov 22 2016, 9:54 PM

• bmansurov moved this task from Code Review to Needs QA on the Reading-Web-Sprint-86-🔪🦃 board.

Change 322081 merged by jenkins-bot:
Avoid a flash of unstyled content on most tablet devices

https://gerrit.wikimedia.org/r/322081

On the Samsung Galaxy Tab 4 and iPad Air 2 iOS 10.2 (the tablets), the sections on the Barack Obama and Los Angeles Lakers pages are already open (not collapsed then open, but already open) when the article is opened. I checked this with Android Browser, Safari, Chrome, and Firefox and it is the same across all browser apps.

I didn't have an Android phone with me at home, but on the iPhone 6S iOS 10.2 I tested, the sections are closed and do not open when the JS loads or when scrolling the page, a section only opens when tapped.

I believe these are the expected results and will move this to the fixed section.

Nicholas.tsg moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-86-🔪🦃 board.Nov 27 2016, 8:46 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 28 2016, 12:01 AM

All done! thanks, @Nicholas.tsg

	F4734045: T150839.gif
	Nov 17 2016, 10:03 AM

Regression: FOUC for tablet usersClosed, ResolvedPublic3 Estimated Story PointsActions