Page MenuHomePhabricator

VE editing of gallery on mobile is broken
Closed, ResolvedPublic1 Estimated Story Points


I tried to edit a gallery on mobile and the UI was not responding. Console revealed the following errors.

[Error] TypeError: undefined is not a constructor (evaluating 'new ve.ui.MWMediaSearchWidget()')
	initialize (load.php:213:382)
	setManager (Anonymous Script 1 (line 110:509))
	addWindows (Anonymous Script 1 (line 104:449))
	getWindow (Anonymous Script 1 (line 100:1001))
	(anonymous function) (load.php:629:687)
	fire (load.php:45:128)
	add (load.php:45:661)
	always (load.php:46:879)
	open (load.php:629:652)
	execute (load.php:536:161)
	execute (load.php:561:855)
	onEditButtonClick (load.php:633:468)
	emit (Anonymous Script 2 (line 18:849))
	onClick (load.php:1023:872)
	(anonymous function)
	dispatch (load.php:65:992)
	handle (load.php:60:487)
[Error] TypeError: undefined is not an object (evaluating 'this.searchWidget.getQuery')
	(anonymous function) (load.php:217:434)
	(anonymous function) (Anonymous Script 1 (line 97:188))
	(anonymous function) (load.php:47:135)
	fire (load.php:45:128)
	add (load.php:45:661)
	(anonymous function) (load.php:47:98)
	each (load.php:5:240)
	(anonymous function) (load.php:47)
	Deferred (load.php:47:933)
	then (load.php:46:977)
	execute (Anonymous Script 1 (line 97:895))
	setup (Anonymous Script 1 (line 112:615))
	(anonymous function) (Anonymous Script 1 (line 102:119))

Browser: Safari

Event Timeline

TheDJ created this task.Nov 16 2016, 10:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2016, 10:33 AM

Change 321882 had a related patch set uploaded (by Esanders):
Separate out resources for media search widget

Arguably we should disable gallery editing on mobile, the layout won't work very well on small screens and neither will drag and drop re-ordering (T150857). Image editing is currently disabled for similar reasons.

Yeah, let's disable galleries on mobile for now.

Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

Change 321882 merged by jenkins-bot:
Separate out resources for media search widget

matmarex closed this task as Resolved.Jan 19 2017, 2:00 PM
matmarex added a subscriber: matmarex.

Looks like this was fixed.