Page MenuHomePhabricator
Create Task
Maniphest T150854

Debug, fix and re-enable flaky tests for uw.ConcurrentQueue
Closed, ResolvedPublic
Actions

Assigned To
matthiasmullie
Authored By
matmarex
Nov 16 2016, 2:19 PM
Tags
Referenced Files
F4730836: consoleText.txt
Nov 16 2016, 2:40 PM
F4730841: consoleText.txt
Nov 16 2016, 2:40 PM
F4730834: consoleText.txt
Nov 16 2016, 2:40 PM
F4730837: consoleText.txt
Nov 16 2016, 2:40 PM
F4730838: consoleText.txt
Nov 16 2016, 2:40 PM
F4730833: consoleText.txt
Nov 16 2016, 2:40 PM
Subscribers
Aklapper
gerritbot
Matanya
matmarex

Details

SubjectRepoBranchLines +/-
Make ConcurrentQueue tests more reliablemediawiki/extensions/UploadWizardmaster+128 -166
Customize query in gerrit

Event Timeline

matmarex created this task.Nov 16 2016, 2:19 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 16 2016, 2:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a comment.Nov 16 2016, 2:22 PM

In https://gerrit.wikimedia.org/r/321877 I commented-out flaky tests for uw.ConcurrentQueue, which recently started failing much more often than they used to (like every other change, rather than about one in a hundred).

I don't know what the exact problem is. uw.ConcurrentQueue is annoying to test because of all the asynchronous stuff, and it seems that the tests try to verify stronger assumptions than what uw.ConcurrentQueue actually guarantees. I don't think any of our actual code is buggy, only the tests are.

Restricted Application added a subscriber: Matanya. · View Herald TranscriptNov 16 2016, 2:23 PM
matmarex added a project: Technical-Debt.Nov 16 2016, 2:24 PM
matmarex added a comment.Nov 16 2016, 2:40 PM

Some recent failures, to aid debugging:

MarkTraceur triaged this task as Low priority.Nov 16 2016, 6:42 PM
MarkTraceur moved this task from Untriaged to Next up on the Multimedia board.
matthiasmullie claimed this task.Nov 28 2016, 2:37 PM
MarkTraceur moved this task from Next up to Doing on the Multimedia board.Nov 28 2016, 5:26 PM
matthiasmullie moved this task from Doing to Needs code review on the Multimedia board.Dec 1 2016, 1:13 PM
gerritbot subscribed.Dec 2 2016, 4:22 PM

Change 324495 had a related patch set uploaded (by Bartosz Dziewoński):
Make ConcurrentQueue tests more reliable

https://gerrit.wikimedia.org/r/324495

gerritbot added a project: Patch-For-Review.Dec 2 2016, 4:22 PM
gerritbot added a comment.Dec 2 2016, 4:26 PM

Change 324495 merged by jenkins-bot:
Make ConcurrentQueue tests more reliable

https://gerrit.wikimedia.org/r/324495

matmarex closed this task as Resolved.Dec 2 2016, 4:29 PM
matmarex removed a project: Patch-For-Review.

The work was done by Matthias, I just tagged the task. I hope the fix sticks. Thanks!

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 2 2016, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits