Page MenuHomePhabricator

Debug, fix and re-enable flaky tests for uw.ConcurrentQueue
Closed, ResolvedPublic

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

In https://gerrit.wikimedia.org/r/321877 I commented-out flaky tests for uw.ConcurrentQueue, which recently started failing much more often than they used to (like every other change, rather than about one in a hundred).

I don't know what the exact problem is. uw.ConcurrentQueue is annoying to test because of all the asynchronous stuff, and it seems that the tests try to verify stronger assumptions than what uw.ConcurrentQueue actually guarantees. I don't think any of our actual code is buggy, only the tests are.

MarkTraceur moved this task from Untriaged to Next up on the Multimedia board.

Change 324495 had a related patch set uploaded (by Bartosz Dziewoński):
Make ConcurrentQueue tests more reliable

https://gerrit.wikimedia.org/r/324495

Change 324495 merged by jenkins-bot:
Make ConcurrentQueue tests more reliable

https://gerrit.wikimedia.org/r/324495

matmarex removed a project: Patch-For-Review.

The work was done by Matthias, I just tagged the task. I hope the fix sticks. Thanks!