Page MenuHomePhabricator

[Regression ?] Inconsistent display of images in Gallery when same image is added multiple times
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Open VE
  2. Go to Insert>Gallery
  3. Add a same image twice
  4. Observe that, there are two of the same image on the left panel inside the gallery dialog
  5. Insert the Gallery
  6. Observe that, on the page it shows both the images (If you save the page, you will see two images in Read mode too)
  7. Reopen the Gallery editing dialog, now there is only one of those images on the left side of the dialog

8.Made a change to this gallery e.g add another different image and click done

  1. Now it updates the display on the page to include only one of the images that has been added twice.

Maybe we dont want to add same image multiple times in Gallery, but it should be consistent in terms of display over the dialog and the page (both in VE and in read mode).

Event Timeline

Ryasmeen created this task.Nov 16 2016, 8:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2016, 8:45 PM
Ryasmeen updated the task description. (Show Details)Nov 16 2016, 8:46 PM

This is a nasty one - we should allow the same image multiple times, and don't want to delete the duplicates in existing galleries.

Tchanders triaged this task as High priority.Nov 17 2016, 8:37 AM
Ryasmeen renamed this task from Inconsistent display of images in Gallery when same image is added multiple times to [Regression] Inconsistent display of images in Gallery when same image is added multiple times.Nov 18 2016, 6:58 PM
Ryasmeen renamed this task from [Regression] Inconsistent display of images in Gallery when same image is added multiple times to [Regression ?] Inconsistent display of images in Gallery when same image is added multiple times.

Change 322428 had a related patch set uploaded (by Tchanders):
Allow the gallery dialog to insert duplicate images initially

https://gerrit.wikimedia.org/r/322428

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

Change 322428 merged by jenkins-bot:
Allow the gallery dialog to insert duplicate images initially

https://gerrit.wikimedia.org/r/322428