Page MenuHomePhabricator

CopyPatrol: restore user whitelist functionality
Closed, ResolvedPublic3 Estimated Story Points

Description

I believe the user whitelist functionality was commented out because we couldn't get it to work locally. I had the same issue, though it did work for me at some point... Not sure if it works on production, so I guess let's get it to work locally, test it and redeploy it.

The French version hasn't been set up yet either. I think you can simply create the page and it will work, but let's test it to be sure. We should also have someone translate the instructional text to French.

English version: https://en.wikipedia.org/wiki/User:EranBot/Copyright/User_whitelist
French version (nonexistent): https://fr.wikipedia.org/wiki/User:EranBot/Copyright/User_whitelist

Event Timeline

kaldari triaged this task as Medium priority.Nov 17 2016, 6:05 PM
kaldari set the point value for this task to 3.

French translation : Ajouter des noms d'utilisateurs par ordre alphabétique, un par ligne, selon le format * [[Utilisateur:Example]]

This works locally for me if we drop the Redis caching stuff. @MusikAnimal, @kaldari - what do you think? Do we need the caching, given that it's only 1 extra API call per page load? Doesn't seem to affect performance from local testing.
We can also put in some checks to see if it's local testing and do the redis only if it's on tool labs.

This works locally for me if we drop the Redis caching stuff. @MusikAnimal, @kaldari - what do you think? Do we need the caching, given that it's only 1 extra API call per page load? Doesn't seem to affect performance from local testing.
We can also put in some checks to see if it's local testing and do the redis only if it's on tool labs.

If you remove the Redis-related variables from your .env it should use the filesystem instead of Redis. Does that work?

It's not so much local performance but the server kittens that we're trying to respect. The whitelist rarely gets changed yet without caching we're fetching on every page load.