Page MenuHomePhabricator

Use action labels instead of just Submit in OATH form
Open, Needs TriagePublic


The Enable and Disable flows of two-factor authentication have progressive action buttons that just state "Submit". Maybe we need cancel buttons as well ?

With the AuthManager flow, there will be a "Change credentials" button and a "Cancel" button. Change credentials is still somewhat user unfriendly I think. Just "Enable", "Disable" would probably be better. Not sure if that is possible in AuthManager.

See also: T137471: Migrate special pages to use AuthManager

Event Timeline

TheDJ created this task.Nov 18 2016, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2016, 11:27 AM

Change 294861 had a related patch set uploaded (by TheDJ):
[WIP] Use AuthManager data change methods

TheDJ updated the task description. (Show Details)Nov 23 2016, 11:14 PM
TheDJ updated the task description. (Show Details)Apr 21 2017, 7:18 PM
TheDJ updated the task description. (Show Details)

Don't you think “Enable credentials” (as primary action) is superior? It's a good UX practice to repeat the main action term especially in environments where the users are confronted with a lot of different actions in similar look and position in different views.

Volker, my last concern was specifically with AuthManager assuming that "a change is a change". Even if that change is adding an additional authentication method. You are not enabling or changing credentials here, but adding an authentication methodology (Enable two-factor authentication is the current special page title for this step).

Technically that will change your credentialing, but that's not what the user cares about at that time, and especially casual computer users will not be able to relate to it. He clicked a "Enable two-factor authentication"-button to start this process, and now he is going to have to click a "Change credentials" button. That's a mistmatch in terminology that will be off-putting to some.