Enable translateMagicWords
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Nov 19 2016, 10:36 AM

Description

Does this needs some broader discussion? Where should be this announced?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Improve and re-enable translateMagicWords	pywikibot/core	master	+60 -17
	Improve and re-enable translateMagicWords	pywikibot/core	master	+22 -8

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T141024 Add Phabricator tasks to comments for buggy cosmetic changes
Resolved	matej_suchanek	T151107 Enable translateMagicWords
Resolved	Xqt	T159997 cosmetic_changes slow down/freeze running bot
Resolved	Dalba	T148959 File regex gets stuck on a link in the caption

Event Timeline

matej_suchanek created this task.Nov 19 2016, 10:36 AM

Change 322401 had a related patch set (by Matěj Suchánek) published:
Improve and re-enable translateMagicWords

https://gerrit.wikimedia.org/r/322401

gerritbot added a project: Patch-For-Review.Nov 19 2016, 10:37 AM

Magul added a project: Pywikibot.Nov 24 2016, 7:57 AM

The reason for deactivating it should be checked.

In fact, I couldn't find it and I feel it could be done by mistake, see T141024#2752275.

I'll check my talk pages and mails. I think there where some problems.

Xqt triaged this task as Low priority.Nov 24 2016, 8:47 PM

In T151107#2822042, @Xqt wrote:

I'll check my talk pages and mails. I think there where some problems.

That's why I created T141024. I could not find anything about.

matej_suchanek moved this task from Backlog to Deactivated code on the Pywikibot-cosmetic-changes board.Feb 15 2017, 9:11 PM

Change 322401 merged by jenkins-bot:
[pywikibot/core] Improve and re-enable translateMagicWords

https://gerrit.wikimedia.org/r/322401

matej_suchanek added a subtask: T159997: cosmetic_changes slow down/freeze running bot.Mar 9 2017, 12:40 PM

Xqt closed subtask T159997: cosmetic_changes slow down/freeze running bot as Resolved.Mar 9 2017, 12:50 PM

I reverted the previous patch with https://gerrit.wikimedia.org/r/#/c/342000 to solve the Problem T159997.
@matej_suchanek could you search for a solution for that problem introduced with that patch?

Change 342002 had a related patch set uploaded (by Xqt; owner: Matěj Suchánek):
[pywikibot/core] Improve and re-enable translateMagicWords

https://gerrit.wikimedia.org/r/342002

textlib.replaceExcept is known to be slow, so it wasn't really wise to call it individually for each magic word. Now that T148959: File regex gets stuck on a link in the caption is fixed, I believe this is the way to go. I will be working on this today.

matej_suchanek added a subtask: T148959: File regex gets stuck on a link in the caption.Mar 9 2017, 5:28 PM

Xqt closed this task as Resolved.Jul 18 2017, 9:26 AM

Change 342002 merged by jenkins-bot:
[pywikibot/core@master] Improve and re-enable translateMagicWords