RFC: Regressions of core should be rethought or solved
Open, HighPublic
Actions

Assigned To

None

Authored By

	Magul
	Nov 19 2016, 2:28 PM

Description

As was pointed by @Xqt in patch review (see: 1) there are some inconsistency and underlying problems in how Bot class is implemented.

There was also pointed that we could inspire ourselves in how it is implemented in Compat.

This issue should be considered as RfC.

Details

	Project	Branch	Lines +/-	Subject
	pywikibot/core	master	+32 -16	[cleanup] Desupport Page.fullVersionHistory() method

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T151110 RFC: Regressions of core should be rethought or solved
Open		None	T104805 textlib.replace_links() does not work as expected
Resolved		Xqt	T136513 Different results of Page.getVersion() between compat and core
Open		Xqt	T145372 generate_user_files.py is no longer able to create a small user-config.py
Resolved		Xqt	T145371 generate_user_files.py does not extract config sections
Open		None	T125963 Breaking change for site.namespaces()
Open		Xqt	T104973 misspelling must not pipe the changed link
Resolved		Xqt	T147159 -always option doesn't work as expected for solve_disambiguation.py
Open		None	T125372 Add documentation to textlib.replace_links
Resolved		Xqt	T131952 Breaking change for templatesWithParams against compat
Open		None	T108444 Log file doesn't contain traceback when script fails by exception
Resolved		Xqt	T147178 Edit counter gives wrong result in replace.py
Open		None	T73646 replace.py: async output messages jumbled with user interaction on main thread
Open		Xqt	T132135 template.py does not show when a page is saved
Open		Xqt	T151727 Port cache_output from compat
Open		None	T61686 fixing_redirects.py: move treat() to pywikibot/textlib
Resolved		Xqt	T168666 revertbot.py infinitely loops over user contribs
Declined		None	T156623 solve_disambiguation.py without pagegenerator crashes
Resolved		Xqt	T180915 Wrong decoding for xml content
Resolved		None	T182854 Add protocol in Page.permalink()
Resolved		Dvorapa	T186394 solve_disambiguation uses slice operator for PageGenerator
Open		None	T118719 solve_disambiguation.py gives possibilities from {{disambiguation}}
Open		None	T106763 Mandatory dependency on mwparserfromhell
Resolved		Ladsgroup	T88069 Add pure python mwparserfromhell to nightlies
Resolved		Xqt	T186316 solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object
Resolved		Dvorapa	T191718 Category tidy should categorize inside /doc subpages of templates
Resolved		Dvorapa	T58188 core Page.templates has incompatible API change from compat
Resolved	BUG REPORT	Xqt	T220261 -parent or -basename cannot be used with create_categories

Event Timeline

Magul created this task.Nov 19 2016, 2:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2016, 2:28 PM

Magul added projects: Pywikibot, Pywikibot-compat-to-core.Nov 19 2016, 2:29 PM

Restricted Application added a subscriber: pywikibot-bugs-list. · View Herald TranscriptNov 19 2016, 2:29 PM

zhuyifei1999 added a subscriber: zhuyifei1999.Nov 20 2016, 5:33 PM

I think there a some regressions against compat which should be rethinked. I wouldn't reduce it to the Bot class only

Xqt renamed this task from Underlying Bot class architecture should be rethinked to Regressions of core should be rethinked.Nov 24 2016, 10:08 AM

Xqt added a subtask: T104805: textlib.replace_links() does not work as expected.

Xqt added a subtask: T136513: Different results of Page.getVersion() between compat and core.Nov 24 2016, 10:11 AM

Xqt renamed this task from Regressions of core should be rethinked to Regressions of core should be rethinked or solved.Nov 24 2016, 10:13 AM

Xqt added subtasks: T145371: generate_user_files.py does not extract config sections, T145372: generate_user_files.py is no longer able to create a small user-config.py.

Xqt added subtasks: T125963: Breaking change for site.namespaces(), T104973: misspelling must not pipe the changed link, T147159: -always option doesn't work as expected for solve_disambiguation.py, T125372: Add documentation to textlib.replace_links, T131952: Breaking change for templatesWithParams against compat, T108444: Log file doesn't contain traceback when script fails by exception, T147178: Edit counter gives wrong result in replace.py, T73646: replace.py: async output messages jumbled with user interaction on main thread, T132135: template.py does not show when a page is saved.Nov 24 2016, 10:32 AM

I added some of the regressions against compat. One main thing is the missing output cache in async mode (see https://gerrit.wikimedia.org/r/#/c/282818/) which leads to some some kind of workaround in replace.py (the callback method which omits the page save message or give a bulk output of 50 pages). Another part is the inappropriate implementation of textlib.replace_links() (see T61686) which leads to broken wiki links.

Xqt added a subtask: T61686: fixing_redirects.py: move treat() to pywikibot/textlib.Nov 24 2016, 10:47 AM

Xqt added a subtask: T151727: Port cache_output from compat.Nov 27 2016, 5:49 PM

Lokal_Profil renamed this task from Regressions of core should be rethinked or solved to RFC: Regressions of core should be rethinked or solved.Dec 20 2016, 8:52 PM

Magul renamed this task from RFC: Regressions of core should be rethinked or solved to RFC: Regressions of core should be rethought or solved.Dec 21 2016, 2:04 PM

Dalba closed subtask T147159: -always option doesn't work as expected for solve_disambiguation.py as Resolved.Jan 15 2017, 10:32 AM

Dalba closed subtask T131952: Breaking change for templatesWithParams against compat as Resolved.Mar 21 2017, 6:30 AM

Xqt added a subtask: T168666: revertbot.py infinitely loops over user contribs.Jun 22 2017, 4:57 PM

Xqt closed subtask T168666: revertbot.py infinitely loops over user contribs as Resolved.Jun 25 2017, 7:01 PM

Xqt triaged this task as High priority.Jun 27 2017, 5:34 PM

Xqt added a subtask: T156623: solve_disambiguation.py without pagegenerator crashes.

Xqt added a subtask: T180915: Wrong decoding for xml content.Nov 20 2017, 10:26 AM

Xqt closed subtask T180915: Wrong decoding for xml content as Resolved.Nov 21 2017, 3:33 PM

Xqt added a subtask: T182854: Add protocol in Page.permalink().Dec 17 2017, 2:18 PM

eflyjason closed subtask T182854: Add protocol in Page.permalink() as Resolved.Dec 19 2017, 3:42 PM

Xqt closed subtask T156623: solve_disambiguation.py without pagegenerator crashes as Declined.Feb 3 2018, 8:55 AM

Xqt added a subtask: T186394: solve_disambiguation uses slice operator for PageGenerator.