Page MenuHomePhabricator

RFC: Regressions of core should be rethought or solved
Open, HighPublic

Description

As was pointed by @Xqt in patch review (see: 1) there are some inconsistency and underlying problems in how Bot class is implemented.

There was also pointed that we could inspire ourselves in how it is implemented in Compat.

This issue should be considered as RfC.

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
ResolvedXqt
OpenXqt
ResolvedXqt
OpenNone
OpenXqt
ResolvedXqt
OpenNone
ResolvedXqt
OpenNone
ResolvedXqt
OpenMpaa
OpenXqt
OpenXqt
OpenNone
ResolvedXqt
DeclinedNone
ResolvedXqt
ResolvedNone
OpenXqt
OpenNone
OpenNone
ResolvedLadsgroup
ResolvedXqt
ResolvedDvorapa
ResolvedDvorapa
ResolvedBUG REPORTXqt

Event Timeline

Magul created this task.Nov 19 2016, 2:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2016, 2:28 PM
Restricted Application added a subscriber: pywikibot-bugs-list. · View Herald TranscriptNov 19 2016, 2:29 PM
Xqt added a comment.Nov 24 2016, 10:07 AM

I think there a some regressions against compat which should be rethinked. I wouldn't reduce it to the Bot class only

Xqt renamed this task from Underlying Bot class architecture should be rethinked to Regressions of core should be rethinked.Nov 24 2016, 10:08 AM
Xqt renamed this task from Regressions of core should be rethinked to Regressions of core should be rethinked or solved.Nov 24 2016, 10:13 AM
Xqt added a comment.Nov 24 2016, 10:47 AM

I added some of the regressions against compat. One main thing is the missing output cache in async mode (see https://gerrit.wikimedia.org/r/#/c/282818/) which leads to some some kind of workaround in replace.py (the callback method which omits the page save message or give a bulk output of 50 pages). Another part is the inappropriate implementation of textlib.replace_links() (see T61686) which leads to broken wiki links.

Lokal_Profil renamed this task from Regressions of core should be rethinked or solved to RFC: Regressions of core should be rethinked or solved.Dec 20 2016, 8:52 PM
Magul renamed this task from RFC: Regressions of core should be rethinked or solved to RFC: Regressions of core should be rethought or solved.Dec 21 2016, 2:04 PM

Change 584196 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Desupport Page.fullVersionHistory() method

https://gerrit.wikimedia.org/r/584196

Change 584196 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Desupport Page.fullVersionHistory() method

https://gerrit.wikimedia.org/r/584196