Page MenuHomePhabricator
Create Task
Maniphest T151212

Make TermIndexEntry's constructor expect the instance of EntityId as an enity id, not the number
Closed, ResolvedPublic
Actions

Description

This would remove the EntityId composing/creation logic out of the TermIndexEntry.

All calls to TermIndexEntry constructor must be adjusted to reflect the change.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use the EntityId instance instead of plain number as entity id in TermIndexEntrymediawiki/extensions/Wikibasemaster+131 -122
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 ResolvedLydia_PintscherT76007 [Epic] add ability to link/refer to foreign items and properties (federation)
 ResolvedLydia_PintscherT149580 Allow access to entity data stored on "foreign" repositories (federation)
 ResolvedWMDE-leszekT150848 Create a dispatching version of TermSearchInteractor
 ResolvedWMDE-leszekT151053 Create repo-aware TermSqlIndex
 DeclinedWMDE-leszekT151210 Add repository name to TermIndexEntry
 ResolvedWMDE-leszekT151212 Make TermIndexEntry's constructor expect the instance of EntityId as an enity id, not the number

Event Timeline

WMDE-leszek created this task.Nov 21 2016, 4:28 PM
gerritbot subscribed.Nov 23 2016, 11:24 AM

Change 322919 had a related patch set (by WMDE-leszek) published:
Use the EntityId instance instead of plain number as entity id in TermIndexEntry

https://gerrit.wikimedia.org/r/322919

gerritbot added a project: Patch-For-Review.Nov 23 2016, 11:24 AM
WMDE-leszek claimed this task.Nov 24 2016, 11:24 AM
WMDE-leszek moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
daniel edited parent tasks, added: T151210: Add repository name to TermIndexEntry; removed: T151053: Create repo-aware TermSqlIndex.Nov 24 2016, 6:03 PM
thiemowmde closed this task as Resolved.Nov 25 2016, 3:39 PM
thiemowmde removed a project: Patch-For-Review.
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Nov 25 2016, 3:49 PM

Change 322919 merged by jenkins-bot:
Use the EntityId instance instead of plain number as entity id in TermIndexEntry

https://gerrit.wikimedia.org/r/322919

WMDE-leszek mentioned this in T151210: Add repository name to TermIndexEntry.Nov 28 2016, 8:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits