Separate TermIndexEntry to the object used in search results and the object used as a mask in search
Closed, ResolvedPublic

Description

Currently it is possible to create incomplete instances of TermIndexEntry. Incomplete instances might be used as a "mask" (object containing search criteria) in term search. Another usage is in the actual search results, where the instance is "complete".

Those two concerns should be split to separate objects. Apart from not mixing two different needs, such separation could also improve the internal implementation of current TermIndexEntry.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2016, 4:36 PM
WMDE-leszek triaged this task as Normal priority.Nov 21 2016, 4:36 PM

Change 323176 had a related patch set uploaded (by WMDE-leszek):
Extract TermIndexMask from TermIndexEntry

https://gerrit.wikimedia.org/r/323176

WMDE-leszek updated the task description. (Show Details)
WMDE-leszek moved this task from Proposed to Review on the Wikidata-Sprint board.
WMDE-leszek claimed this task.

Change 323853 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Cleanups to TermIndexSearchCriteria related code

https://gerrit.wikimedia.org/r/323853

Change 323176 merged by jenkins-bot:
Extract TermIndexSearchCriteria from TermIndexEntry

https://gerrit.wikimedia.org/r/323176

Change 323853 merged by jenkins-bot:
Cleanups to TermIndexSearchCriteria related code

https://gerrit.wikimedia.org/r/323853

WMDE-leszek closed this task as Resolved.Nov 29 2016, 10:13 AM
WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint board.