Page MenuHomePhabricator
Create Task
Maniphest T151236

[Regression wmf.?] Editnotices are not displayed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The page Bharatiya Janata Party contains an edit/page notice, but it is not presented to the users in the VisualEditor.

This seems to go for both editnotices (aka page and namespace notices) as well as edit intros.

Details

SubjectRepoBranchLines +/-
Move around code that sets up edit notices to ensure it runs after we receive the notices to displaymediawiki/extensions/VisualEditorwmf/1.29.0-wmf.3+43 -30
Move around code that sets up edit notices to ensure it runs after we receive the notices to displaymediawiki/extensions/VisualEditormaster+43 -30
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Nov 21 2016, 8:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2016, 8:12 PM
TheDJ added a subscriber: Krenair.Nov 21 2016, 8:12 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Nov 21 2016, 8:13 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF edited subscribers, added: • AlexMonk-WMF, Esanders; removed: Krenair.
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptNov 21 2016, 8:13 PM
• AlexMonk-WMF added a comment.Nov 22 2016, 5:26 AM

Seems ve.ui.MWNoticesPopupTool is getting constructed before ve.init.mw.ArticleTarget.prototype.loadSuccess has run

• AlexMonk-WMF claimed this task.Nov 22 2016, 5:42 AM
gerritbot subscribed.Nov 22 2016, 5:44 AM

Change 322828 had a related patch set uploaded (by Alex Monk):
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/322828

gerritbot added a project: Patch-For-Review.Nov 22 2016, 5:44 AM
gerritbot added a comment.Nov 22 2016, 11:27 PM

Change 322828 merged by jenkins-bot:
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/322828

gerritbot added a comment.Nov 22 2016, 11:31 PM

Change 323080 had a related patch set uploaded (by Jforrester):
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/323080

Jdforrester-WMF mentioned this in T151423: [Regression pre-wmf.4] Edit notices dialog pops up every time I open VE.Nov 23 2016, 12:31 AM
gerritbot added a comment.Nov 23 2016, 1:28 AM

Change 323080 merged by jenkins-bot:
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/323080

Jdforrester-WMF renamed this task from Editnotices are not displayed to [Regression wmf.?] Editnotices are not displayed.Nov 23 2016, 1:30 AM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)), MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)); removed Patch-For-Review.
Jdforrester-WMF subscribed.Nov 23 2016, 1:46 AM

This is now live in production; sorry for the disruption.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL