Page MenuHomePhabricator

[Regression wmf.?] Editnotices are not displayed
Closed, ResolvedPublic1 Story Points

Description

The page Bharatiya Janata Party contains an edit/page notice, but it is not presented to the users in the VisualEditor.

This seems to go for both editnotices (aka page and namespace notices) as well as edit intros.

Event Timeline

TheDJ created this task.Nov 21 2016, 8:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2016, 8:12 PM
TheDJ added a subscriber: Krenair.Nov 21 2016, 8:12 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Nov 21 2016, 8:13 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited subscribers, added: AlexMonk-WMF, Esanders; removed: Krenair.
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptNov 21 2016, 8:13 PM

Seems ve.ui.MWNoticesPopupTool is getting constructed before ve.init.mw.ArticleTarget.prototype.loadSuccess has run

Change 322828 had a related patch set uploaded (by Alex Monk):
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/322828

Change 322828 merged by jenkins-bot:
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/322828

Change 323080 had a related patch set uploaded (by Jforrester):
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/323080

Change 323080 merged by jenkins-bot:
Move around code that sets up edit notices to ensure it runs after we receive the notices to display

https://gerrit.wikimedia.org/r/323080

Jdforrester-WMF renamed this task from Editnotices are not displayed to [Regression wmf.?] Editnotices are not displayed.Nov 23 2016, 1:30 AM
Jdforrester-WMF closed this task as Resolved.

This is now live in production; sorry for the disruption.