Page MenuHomePhabricator
Create Task
Maniphest T151266

Saving article with lots of images appears to block loading of subsequent articles (until images fetched?)
Closed, InvalidPublic
Actions

Description

Probably need a spike to investigate this.

Repro:

  • Open an article and tap save on the bottom toolbar
  • Now tap a link
  • When that new article opens, tap save
  • Repeat the a few times, as I did with the following:

Screen Shot 2016-11-21 at 4.55.43 PM.png (1×974 px, 286 KB)

The issue I'm seeing is, after tapping the save button, then tapping the link, the link's article hangs for a long time. It appears this hanging is dependent on how many images the saved article had. As soon as the console stops showing "SDWebImageManager" messages the article appears, but many articles have dozens if not 100+ images so the hang time can be quite long.

Noticed this while browsing on a wifi network, iOS 10.1 iPhone 6s sim.

Tap for animation:

delay.mov.gif (720×396 px, 4 MB)

Related Objects

Event Timeline

Mhurd created this task.Nov 21 2016, 11:05 PM
Restricted Application edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (Administrative). · View Herald TranscriptNov 21 2016, 11:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mhurd added a subscriber: • JMinor.Nov 21 2016, 11:05 PM

@JMinor Potentially need a quick-ish fix for this if others can repro...

Mhurd updated the task description. (Show Details)Nov 21 2016, 11:07 PM
Mhurd updated the task description. (Show Details)
• JMinor triaged this task as Low priority.Nov 21 2016, 11:09 PM

This might be a connection issue? I saved the same series of articles, and then clicked through from Europe articles to several others and all loaded correctly. Maybe I'm missing a step?

Mhurd added subscribers: JoeWalsh, • Fjalapeno.Nov 21 2016, 11:09 PM

@JoeWalsh @Fjalapeno Can u guys repro this?

Mhurd updated the task description. (Show Details)Nov 21 2016, 11:15 PM
Mhurd added a comment.Nov 21 2016, 11:17 PM

@JMinor I uploaded a gif. It seems like the saved images fetches are happening on the main thread (from the symptoms) but I haven't had time to confirm.

JoeWalsh added a comment.Nov 21 2016, 11:20 PM

I've definitely seen this before - I think it has to do with the max concurrent operation count on the image loading queue. We should investigate setting separate queues (or adjusting queue priority) to ensure images loaded from the foreground aren't blocking those downloading in the background.

Mhurd added a comment.Nov 21 2016, 11:22 PM

@JMinor But ya you may be right about it being connection dependent. I can try again when I'm back tomorrow on a dif network. I'm on wifi here and it seems snappy... speed test said 6Mbps... so not blazing...

Mhurd added a comment.Nov 21 2016, 11:23 PM

@JoeWalsh oh cool that may be a pretty easy fix

Josve05a added projects: iOS-app-feature-Saved, iOS-app-Bugs.Nov 22 2016, 10:13 AM
JoeWalsh mentioned this in rAPIOS0dcba9a1724e: Merge branch 'develop' into bug/image_downloads/T151266.Nov 22 2016, 7:41 PM
JoeWalsh mentioned this in rAPIOSc9fd19e69c16: Merge branch 'develop' into bug/image_downloads/T151266.Nov 22 2016, 9:18 PM
JoeWalsh mentioned this in rAPIOS19f160cc75e6: Merge branch 'develop' into bug/image_downloads/T151266.Nov 28 2016, 12:17 PM
JoeWalsh mentioned this in rAPIOSbfeca4d71516: Merge branch 'develop' into bug/image_downloads/T151266.Nov 28 2016, 12:29 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Nov 28 2016, 7:14 PM
JoeWalsh mentioned this in rAPIOS4cff7b640d6c: Merge branch 'develop' into bug/image_downloads/T151266.Nov 28 2016, 8:13 PM
Mhurd added a comment.Nov 29 2016, 12:14 AM

Added some steps to repro which don't even involve tapping save...
https://github.com/wikimedia/wikipedia-ios/pull/1071#issuecomment-262361340

• JMinor moved this task from Needs Engineering Sync to Needs Acceptance Criteria on the iOS-app-v5.3.1-Shoehorn board.Nov 29 2016, 7:20 PM
• JMinor edited projects, added iOS-app-v5.3.2-Lighthouse; removed iOS-app-v5.3.1-Shoehorn.
• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.3.2-Lighthouse board.
JoeWalsh mentioned this in rAPIOS40819d01fd56: Merge branch 'develop' into bug/image_downloads/T151266.Nov 29 2016, 8:30 PM
JoeWalsh mentioned this in rAPIOSc7c630bb401e: Merge branch 'develop' into bug/image_downloads/T151266.Dec 1 2016, 2:07 PM
JoeWalsh mentioned this in rAPIOS6a12a6a20905: Merge branch 'develop' into bug/image_downloads/T151266.
JoeWalsh mentioned this in rAPIOSc80b961069d3: Merge remote-tracking branch 'origin/bug/image_downloads/T151266' into….
• Fjalapeno mentioned this in rAPIOS055c1bd857e1: Merge branch 'develop' into bug/image_downloads/T151266.Dec 5 2016, 4:13 PM
• JMinor raised the priority of this task from Low to Medium.Dec 5 2016, 7:52 PM
• JMinor added a comment.Dec 5 2016, 7:55 PM

Potentially adopt lazy loading of images as a solution.

• JMinor removed a project: iOS-app-v5.3.2-Lighthouse.Dec 7 2016, 1:28 AM
JoeWalsh mentioned this in rAPIOSd2ae6945eb48: Merge branch 'develop' into bug/image_downloads/T151266.Dec 7 2016, 9:49 PM
Mhurd added a comment.Mar 23 2017, 4:22 PM

I'd be wary of working on lazy loading until we know what's going on.

Mhurd added a comment.Mar 23 2017, 4:27 PM

Probably close this, but need to double check that this is not an issue anymore.

• JMinor closed this task as Invalid.Apr 3 2017, 9:45 PM

Will also be changed again by SDWebImages changes, so closing this.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL