Page MenuHomePhabricator

CopyPatrol: Manage errors of the Whitelist's content parser
Closed, ResolvedPublic1 Estimated Story Points

Description

Per bug T151354 :

  • manage cases of wrong format of the local wiki Whitelist page, for example by ignoring wrong lines
  • add better error than T151354 for explain the problem to the user

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kaldari renamed this task from CopyPatrol: Menage errors of the Whitelist's content parser to CopyPatrol: Manage errors of the Whitelist's content parser.Dec 1 2016, 4:14 AM
kaldari updated the task description. (Show Details)
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
Samwilson subscribed.

I think the root cause of the referenced error here comes up when a whitelist page (User:EranBot/Copyright/User_whitelist in whichever Wikipedia is in use) doesn't have any links.

And I guess the whitelist used to be parsed directly? (That's why the asterisk made a difference?) But that's not the case now — it just looks at pages linked from the whitelist, finds all of them and strips the text before the first colon character.

The undefined index error is fixed in PR #44 (see https://github.com/wikimedia/CopyPatrol/pull/44/files#diff-c97cd2082208c36198f33feab51ccc4cL255 ).

I think this is resolved now. @Framawiki can you confirm?

DannyH set the point value for this task to 1.Dec 6 2016, 11:15 PM
Framawiki claimed this task.

Works for me. Thanks