Page MenuHomePhabricator

Investigate country code = XX making it to Ingenico
Closed, ResolvedPublic1 Estimated Story Points

Description

@MBeat33 found a couple orders that failed on I_OWP (last comment on T149137). We sent country code XX in the API call. Figure out why, and try to no do that.

Event Timeline

ggellerman added a project: Spike.
ggellerman set the point value for this task to 1.

The users encountering this have mainly been coming in via email campaigns (makes sense, as banners only target the people who we can geoIP lookup). @Pcoombe , what do you think of adding some logic to DonateWiki that would show a message and link users to https://wikimediafoundation.org/wiki/Ways_to_Give#creditdebit when the country code is garbage? We could also do that in DonationInterface, but it would save donors a step to do it on donate.wm.o

Garbage codes include: 'XX', 'EU', 'AP', 'A1', 'A2', 'O1'

Change 323242 had a related patch set uploaded (by Ejegg):
WIP better message when geoIP lookup fails

https://gerrit.wikimedia.org/r/323242

Change 323254 had a related patch set uploaded (by Ejegg):
Allow getRequiredFields before unstagedData is set

https://gerrit.wikimedia.org/r/323254

Great idea @Ejegg. Added a basic link when the country code is garbage: https://donate.wikimedia.org/?country=XX

@MBeat33 Is this messaging okay with you?

Thank you @Pcoombe ! Looks good on desktop. On mobile it's behind the WMF logo.

Is the country code really required in that API call?

@Platonides Yep, Ingenico lists that as one of the required parameters to INSERT_ORDERWITHPAYMENT

Change 323254 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Allow getRequiredFields before unstagedData is set

https://gerrit.wikimedia.org/r/323254

Change 323242 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Better message when geoIP lookup fails

https://gerrit.wikimedia.org/r/323242

One more on 2018-11-05, with the Connect integration: 60400492.1

Ejegg claimed this task.

I think this was fixed with https://gerrit.wikimedia.org/r/478364