Page MenuHomePhabricator
Create Task
Maniphest T151418

CentralNotice: If possible, reduce Varnish cache time for SpecialBannerLoader errors
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Seems like an easy win, but we should get feedback from Ops

Details

SubjectRepoBranchLines +/-
SpecialBannerLoader: reduce s-maxage on caught exceptionmediawiki/extensions/CentralNoticemaster+31 -7
Customize query in gerrit

Related Objects

Event Timeline

AndyRussG created this task.Nov 22 2016, 11:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2016, 11:45 PM
AndyRussG renamed this task from Spike: CentralNotice: Can we reduce Varnish cacjhe time for SpecialBannerLoader errors, and if so, by how much to Spike: CentralNotice: Can we reduce Varnish cache time for SpecialBannerLoader errors, and if so, by how much.Nov 22 2016, 11:50 PM
AndyRussG mentioned this in T149873: CentralNotice: Review and update Varnish caching for Special:BannerLoader.
gerritbot subscribed.Nov 23 2016, 12:31 AM

Change 322976 had a related patch set uploaded (by AndyRussG):
SpecialBannerLoader: reduce s-maxage on caught exception

https://gerrit.wikimedia.org/r/322976

gerritbot added a project: Patch-For-Review.Nov 23 2016, 12:31 AM
gerritbot added a comment.Nov 23 2016, 2:29 AM

Change 322976 merged by jenkins-bot:
SpecialBannerLoader: reduce s-maxage on caught exception

https://gerrit.wikimedia.org/r/322976

AndyRussG renamed this task from Spike: CentralNotice: Can we reduce Varnish cache time for SpecialBannerLoader errors, and if so, by how much to CentralNotice: If possible, reduce Varnish cache time for SpecialBannerLoader errors.Nov 23 2016, 6:59 PM
• DStrine moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.Nov 23 2016, 11:57 PM
• DStrine moved this task from Sprint +3 to Sprint +1 on the Fundraising-Backlog board.Jan 18 2017, 8:03 PM
• DStrine moved this task from Sprint +1 to Current Sprint and Completed in Q3 2016-17 on the Fundraising-Backlog board.Jan 18 2017, 11:39 PM
• DStrine added a project: Fundraising Sprint Baudelaire Bowdlerizer.Jan 19 2017, 12:02 AM
AndyRussG moved this task from Backlog to Pending Deployment on the Fundraising Sprint Baudelaire Bowdlerizer board.Jan 24 2017, 6:13 PM
AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Baudelaire Bowdlerizer board.Jan 26 2017, 4:54 PM

This went out with the train this week, so it was deployed to Meta, which is where we go to load banners, on Tuesday. I verified that it's working as advertised, so I'll close the ticket. Thanks!! :)

AndyRussG closed this task as Resolved.Jan 26 2017, 4:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL